Skip to content

Commit 41f89a7

Browse files
committed
Move back RoutingMiddleware in order
It need to be executed after the error handling middleware
1 parent 2820794 commit 41f89a7

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/ServicesProvider/FrameworkService.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,25 @@ protected function registerRoutes(SlimApp $app, SprinkleRoutesRepository $routes
8989

9090
/**
9191
* Load and register all middlewares.
92+
* Last registered middleware is executed first.
9293
*
9394
* @param SlimApp $app
9495
* @param SprinkleMiddlewareRepository $middlewareRepository
9596
*/
9697
protected function registerMiddlewares(SlimApp $app, SprinkleMiddlewareRepository $middlewareRepository): void
9798
{
99+
// Routing middleware can be executed last.
100+
// It should be executed after any error handling middleware.
101+
$app->addRoutingMiddleware();
102+
98103
// Add the registered Middlewares
99104
foreach ($middlewareRepository as $middleware) {
100105
$app->addMiddleware($middleware);
101106
}
102107

103-
// Add default Slim middlewares
108+
// Body parsing middleware should be executed first, so other middleware
109+
// can access the parsed body.
104110
$app->addBodyParsingMiddleware();
105-
$app->addRoutingMiddleware();
106111
}
107112

108113
/**

0 commit comments

Comments
 (0)