Establish test standards for k8s + github dependencies

- Add test workflow
- Add environment service tests

Author: bbedward

.github/workflows/ci_test.yml

@@ -0,0 +1,25 @@
+name: Run tests
+
+on:
+  push:
+    branches: [master]
+
+concurrency:
+  group: environment-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Execute tests
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Go with cache
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: ./go.mod
+
+      - name: Run tests
+        run: |
+          go test -v ./...

.mockery.yml

@@ -150,6 +150,15 @@ packages:
           filename: webhook_repository_mock.go
           mockname: WebhookRepositoryMock
           outpkg: mocks_repository_webhook
+  github.com/unbindapp/unbind-api/internal/infrastructure/k8s:
+    config:
+      dir: ./mocks/infrastructure/k8s
+    interfaces:
+      KubeClientInterface:
+        config:
+          filename: kubeclient_mock.go
+          mockname: KubeClientMock
+          outpkg: mocks_infrastructure_k8s
   github.com/unbindapp/unbind-api/internal/repositories/repositories:
     config:
       dir: ./mocks/repositories
@@ -158,4 +167,40 @@ packages:
         config:
           filename: repositories_mock.go
           mockname: RepositoriesMock
-          outpkg: mocks_repositories
+          outpkg: mocks_repositories
+  github.com/unbindapp/unbind-api/internal/integrations/github:
+    config:
+      dir: ./mocks/integrations/github
+    interfaces:
+      GithubClientInterface:
+        config:
+          filename: github_client_mock.go
+          mockname: GithubClientMock
+          outpkg: mocks_integrations_github
+  github.com/unbindapp/unbind-api/internal/services/webooks:
+    config:
+      dir: ./mocks/services/webhooks
+    interfaces:
+      WebhooksServiceInterface:
+        config:
+          filename: webhooks_service_mock.go
+          mockname: WebhooksServiceMock
+          outpkg: mocks_services_webhooks
+  github.com/unbindapp/unbind-api/internal/services/variables:
+    config:
+      dir: ./mocks/services/variables
+    interfaces:
+      VariablesServiceInterface:
+        config:
+          filename: variables_service_mock.go
+          mockname: VariablesServiceMock
+          outpkg: mocks_services_variables
+  github.com/unbindapp/unbind-api/internal/deployctl:
+    config:
+      dir: ./mocks/deployctl
+    interfaces:
+      DeploymentControllerInterface:
+        config:
+          filename: deployctl_mock.go
+          mockname: DeploymentControllerMock
+          outpkg: mocks_deployctl

Makefile

@@ -23,6 +23,9 @@ migrate\:checksum:
 interfaces:
 	@echo "Generating interfaces..."
 	@go generate ./internal/repositories/...
+	@go generate ./internal/infrastructure/...
+	@go generate ./internal/services/...
+	@go generate ./internal/deployctl/...
 	@echo "Generating mocks..."
 	@go run github.com/vektra/mockery/v2@latest
 

README.md

@@ -4,7 +4,7 @@
 
 ![GitHub License](https://img.shields.io/github/license/unbindapp/unbind-api?style=for-the-badge&color=blue)
 ![GitHub go.mod Go version](https://img.shields.io/github/go-mod/go-version/unbindapp/unbind-api?style=for-the-badge&color=00ADD8)
-![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/unbindapp/unbind-api/ci_master.yml?style=for-the-badge&label=BUILD)
+![GitHub Workflow Test Status](https://img.shields.io/github/actions/workflow/status/unbindapp/unbind-api/ci_test.yml?style=for-the-badge&label=TESTS)
 ![GitHub Stars](https://img.shields.io/github/stars/unbindapp/unbind-api?style=for-the-badge&color=gold)
 ![GitHub Issues](https://img.shields.io/github/issues/unbindapp/unbind-api?style=for-the-badge&color=red)
 ![GitHub Pull Requests](https://img.shields.io/github/issues-pr/unbindapp/unbind-api?style=for-the-badge&color=purple)

go.mod

@@ -59,6 +59,7 @@ require (
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/ProtonMail/go-crypto v1.3.0 // indirect
 	github.com/alexflint/go-filemutex v1.3.0 // indirect
+	github.com/alicebob/miniredis/v2 v2.35.0 // indirect
 	github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.10 // indirect
 	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.30 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.34 // indirect
@@ -190,6 +191,7 @@ require (
 	github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8 // indirect
 	github.com/xlab/treeprint v1.2.0 // indirect
 	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
+	github.com/yuin/gopher-lua v1.1.1 // indirect
 	go.opentelemetry.io/auto/sdk v1.1.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace v0.61.0 // indirect

go.sum

@@ -30,6 +30,8 @@ github.com/ajg/form v1.5.1 h1:t9c7v8JUKu/XxOGBU0yjNpaMloxGEJhUkqFRq0ibGeU=
 github.com/ajg/form v1.5.1/go.mod h1:uL1WgH+h2mgNtvBq0339dVnzXdBETtL2LeUXaIv25UY=
 github.com/alexflint/go-filemutex v1.3.0 h1:LgE+nTUWnQCyRKbpoceKZsPQbs84LivvgwUymZXdOcM=
 github.com/alexflint/go-filemutex v1.3.0/go.mod h1:U0+VA/i30mGBlLCrFPGtTe9y6wGQfNAWPBTekHQ+c8A=
+github.com/alicebob/miniredis/v2 v2.35.0 h1:QwLphYqCEAo1eu1TqPRN2jgVMPBweeQcR21jeqDCONI=
+github.com/alicebob/miniredis/v2 v2.35.0/go.mod h1:TcL7YfarKPGDAthEtl5NBeHZfeUQj6OXMm/+iu5cLMM=
 github.com/anchore/go-struct-converter v0.0.0-20221118182256-c68fdcfa2092 h1:aM1rlcoLz8y5B2r4tTLMiVTrMtpfY0O8EScKJxaSaEc=
 github.com/anchore/go-struct-converter v0.0.0-20221118182256-c68fdcfa2092/go.mod h1:rYqSE9HbjzpHTI74vwPvae4ZVYZd1lue2ta6xHPdblA=
 github.com/andybalholm/brotli v1.0.4/go.mod h1:fO7iG3H7G2nSZ7m0zPUDn85XEX2GTukHGRSepvi9Eig=
@@ -666,6 +668,8 @@ github.com/yudai/golcs v0.0.0-20170316035057-ecda9a501e82/go.mod h1:lgjkn3NuSvDf
 github.com/yudai/pp v2.0.1+incompatible/go.mod h1:PuxR/8QJ7cyCkFp/aUDS+JY727OFEZkTdatxwunjIkc=
 github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
 github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
+github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M=
+github.com/yuin/gopher-lua v1.1.1/go.mod h1:GBR0iDaNXjAgGg9zfCvksxSRnQx76gclCIb7kdAd1Pw=
 github.com/zalando/postgres-operator v1.14.0 h1:C8+n26C8v6fPB1SNW+Y8X6oQoEHufzGJXJzYPlix+zw=
 github.com/zalando/postgres-operator v1.14.0/go.mod h1:ZTHY3sVfHgLLRpTgyR/44JcumbACeJBjztr3o1yHBdc=
 github.com/zclconf/go-cty v1.16.3 h1:osr++gw2T61A8KVYHoQiFbFd1Lh3JOCXc/jFLJXKTxk=

internal/deployctl/deployctl.go

@@ -46,29 +46,31 @@ type DeploymentJobRequest struct {
 }
 
 // Handles triggering builds for services
+//
+//go:generate go run -mod=mod github.com/vburenin/ifacemaker -f "*.go" -i DeploymentControllerInterface -p deployctl -s DeploymentController -o deployctl_iface.go
 type DeploymentController struct {
 	cfg             *config.Config
-	k8s             *k8s.KubeClient
+	k8s             k8s.KubeClientInterface
 	jobQueue        *queue.Queue[DeploymentJobRequest]
 	dependentQueue  *queue.Queue[DeploymentJobRequest]
 	ctx             context.Context
 	cancelFunc      context.CancelFunc
-	repo            *repositories.Repositories
-	githubClient    *github.GithubClient
-	webhookService  *webhooks_service.WebhooksService
-	variableService *variables_service.VariablesService
+	repo            repositories.RepositoriesInterface
+	githubClient    github.GithubClientInterface
+	webhookService  webhooks_service.WebhooksServiceInterface
+	variableService variables_service.VariablesServiceInterface
 }
 
 func NewDeploymentController(
 	ctx context.Context,
 	cancel context.CancelFunc,
 	cfg *config.Config,
-	k8s *k8s.KubeClient,
+	k8s k8s.KubeClientInterface,
 	redisClient *redis.Client,
-	repositories *repositories.Repositories,
-	githubClient *github.GithubClient,
-	webeehookService *webhooks_service.WebhooksService,
-	variableService *variables_service.VariablesService) *DeploymentController {
+	repositories repositories.RepositoriesInterface,
+	githubClient github.GithubClientInterface,
+	webeehookService webhooks_service.WebhooksServiceInterface,
+	variableService variables_service.VariablesServiceInterface) *DeploymentController {
 	jobQueue := queue.NewQueue[DeploymentJobRequest](redisClient, BUILDER_QUEUE_KEY)
 	dependentQueue := queue.NewQueue[DeploymentJobRequest](redisClient, DEPENDENT_SERVICES_QUEUE_KEY)