Skip to content

Runtime config should be put in config/runtime.exs? #87

@kayuapi

Description

@kayuapi

Hi all,

currently the guide shows that we configure the runtime environment like this: https://github.com/ueberauth/ueberauth_google/blob/master/README.md#installation

Use that if you want to read client ID/secret from the environment variables in the run time:

config :ueberauth, Ueberauth.Strategy.Google.OAuth,
client_id: {System, :get_env, ["GOOGLE_CLIENT_ID"]},
client_secret: {System, :get_env, ["GOOGLE_CLIENT_SECRET"]}

Should we put the config in config/runtime.exs like the following:

config :ueberauth, Ueberauth.Strategy.Google.OAuth,
client_id: System.get_env("GOOGLE_CLIENT_ID"),
client_secret: System.get_env("GOOGLE_CLIENT_SECRET")

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions