[core] early return required

[einar-hjortdal]

Note: maybe I am forgetting something.

I have noticed that, in this component, I am required to use an early return null:

If I instead did the following (only returning when requiresShipping is true):

const Properties = component(({ inventoryItemData, onInput }) => {
  const { requiresShipping, material, weight, length, height, width } = inventoryItemData
  const { t } = useTranslation('inventoryItems.shipping.properties')
  if (requiresShipping) {
  return (
    <>
    ...

What happens is that, whenever requiresShipping switches from true to false, the Properties component is still being rendered. Then when requiresShipping switches from false to true, a new Properties component is rendered below the old one.

Why does this happen?

[atellmer]

It looks like a bug.
Could you provide a minimal example to reproduce it?
Also, could you try explicitly returning null instead of false and wrapping the problematic section in a div to see if the incorrect behavior persists?

[einar-hjortdal]

It looks like a bug. Could you provide a minimal example to reproduce it?

I'll try when I have some time

Also, could you try explicitly returning null instead of false and wrapping the problematic section in a div to see if the incorrect behavior persists?

I have tried those and the behavior persisted.