fix: add SSR check for error-boundary

atellmer · atellmer · commit 9df995ffc8d9 · 2024-12-27T21:28:10.000+05:00
diff --git a/packages/core/src/workloop/workloop.ts b/packages/core/src/workloop/workloop.ts
@@ -394,9 +394,10 @@ function mount(fiber: Fiber, prev: Fiber, $scope: Scope) {
 
       component.children = result as Array<Instance>;
     } catch (err) {
+      const isSSR = detectIsSSR();
+
       if (detectIsPromise(err)) {
         const promise = err;
-        const isSSR = detectIsSSR();
         const reset = createResetClosure(fiber, prev, $scope);
 
         if (!isSSR) {
@@ -415,7 +416,7 @@ function mount(fiber: Fiber, prev: Fiber, $scope: Scope) {
         }
       } else {
         component.children = [];
-        fiber.setError(err);
+        !isSSR && fiber.setError(err);
       }
     }
   } else if (detectIsVirtualNodeFactory(inst)) {

Original file line number	Diff line number	Diff line change
`@@ -394,9 +394,10 @@ function mount(fiber: Fiber, prev: Fiber, $scope: Scope) {`
`394`	`394`
`395`	`395`	`component.children = result as Array<Instance>;`
`396`	`396`	`} catch (err) {`
	`397`	`+ const isSSR = detectIsSSR();`
	`398`	`+`
`397`	`399`	`if (detectIsPromise(err)) {`
`398`	`400`	`const promise = err;`
`399`		`- const isSSR = detectIsSSR();`
`400`	`401`	`const reset = createResetClosure(fiber, prev, $scope);`
`401`	`402`
`402`	`403`	`if (!isSSR) {`
`@@ -415,7 +416,7 @@ function mount(fiber: Fiber, prev: Fiber, $scope: Scope) {`
`415`	`416`	`}`
`416`	`417`	`} else {`
`417`	`418`	`component.children = [];`
`418`		`- fiber.setError(err);`
	`419`	`+ !isSSR && fiber.setError(err);`
`419`	`420`	`}`
`420`	`421`	`}`
`421`	`422`	`} else if (detectIsVirtualNodeFactory(inst)) {`