app: Improve 500 handler (#95)

* app: Improve 500 handler

* Do not accidentally handle other errors (like 404s).
* Actually set a 500 status code for these.

Change-Id: Ic7202fe9899a8b625b3751bc085d19980334ff68

* auto update of tag

---------

Co-authored-by: Github Action <[email protected]>

Author: supertassu

helm-quarry/values.yaml

@@ -1,6 +1,6 @@
 web:
   repository: 'quay.io/wikimedia-quarry/quarry'
-  tag: pr-94 # web tag managed by github actions
+  tag: pr-95 # web tag managed by github actions
   resources:
     requests:
       memory: "300Mi"
@@ -11,7 +11,7 @@ web:
 
 worker:
   repository: 'quay.io/wikimedia-quarry/quarry'
-  tag: pr-94 # worker tag managed by github actions
+  tag: pr-95 # worker tag managed by github actions
   resources:
     requests:
       memory: "400Mi"

quarry/web/app.py

@@ -1,5 +1,6 @@
 from flask import current_app, Flask, render_template, g, Response
 from flask_caching import Cache
+from werkzeug.exceptions import HTTPException
 from werkzeug.middleware.proxy_fix import ProxyFix
 
 from .config import get_config
@@ -31,7 +32,10 @@ def kill_context(exception=None):
 
 
 def handle_internal_error(e: Exception):
-    return render_template("500.html")
+    if isinstance(e, HTTPException):
+        return e
+    current_app.logger.error("Failed to handle request", exc_info=e)
+    return render_template("500.html"), 500
 
 
 def create_app(test_config=None):