execution stuck

[delanym]

Hi. I tried this basic config on my project.

    <plugin>
      <groupId>se.bjurr.gitchangelog</groupId>
      <artifactId>git-changelog-maven-plugin</artifactId>
      <version>1.64</version>
      <executions>
        <execution>
          <id>GenerateGitChangelog</id>
          <phase>generate-sources</phase>
          <goals>
            <goal>git-changelog</goal>
          </goals>
          <configuration>
            <templateContent>
              <![CDATA[
# Changelog
Changelog of My Project.
              ]]>
            </templateContent>
            <skip>false</skip>
          </configuration>
        </execution>
      </executions>
    </plugin>

When I run mvn clean install -e -X the output goes on ad infinitum.

...
[main] [DEBUG] Work left: 12892
[main] [DEBUG] Work left: 13001
[main] [DEBUG] Work left: 13106
[main] [DEBUG] Work left: 13226
[main] [DEBUG] Work left: 13323
[main] [DEBUG] Work left: 13401
[main] [DEBUG] Work left: 13480
[main] [DEBUG] Work left: 13790
[main] [DEBUG] Work left: 13763
[main] [DEBUG] Work left: 13830
[main] [DEBUG] Work left: 13901
[main] [DEBUG] Work left: 13986
...

[tomasbjerre]

Can you repeat this in an open repository? Something that I can access.

[delanym]

I tried it in https://github.com/apache/maven/ and it works fine. The commit history is clean and short.

The repository I work on is a different story. The history is labyrinthine and with hundreds of merge commits. There over 500 separate projects in this multi-module build, and I need the plugin to run for each, getting the last 100/1000 commits that touched anything in the directory.

You can tell me if this is possible, but if the plugin is going to trawl through every commit in the history I doubt it.

[delanym]

It seems like a get-the-dom approach, rather than a pull-as-needed approach. If my template doesn't ask for anything, why query the repo at all?

To replicate

git clone https://github.com/mysql/mysql-server.git
cd mysql-server
git checkout -b master
java -jar ../git-changelog-command-line-1.55.jar -std -tec "#Change log"

It should get stuck.

BTW, why do I need to have a master branch?

[tomasbjerre]

I'll have a look when I find the time.

master is needed because of default value of parameter.

https://github.com/tomasbjerre/git-changelog-command-line

...
-tr, --to-ref <string>                     To ref.
                                           <string>: any string
                                           Default: refs/heads/master
...

[JohT]

Reproduce

If it's of any help: It seems that I have the same issue. It should theoretically be reproducible:

• Clone https://github.com/JohT/showcase-quarkus-eventsourcing.git
• Execute mvn compile

This leads to

[DEBUG] Configuring mojo se.bjurr.gitchangelog:git-changelog-maven-plugin:1.96.0:git-changelog from plugin realm ClassRealm[plugin>se.bjurr.gitchangelog:git-changelog-maven-plugin:1.96.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@251a69d7]
[DEBUG] Configuring mojo 'se.bjurr.gitchangelog:git-changelog-maven-plugin:1.96.0:git-changelog' with basic configurator -->
[DEBUG]   (f) customIssues = []
[DEBUG]   (f) extendedHeaders = {}
[DEBUG]   (f) extendedVariables = {}
[DEBUG]   (f) extendedVariablesCli = []
[DEBUG]   (f) templateFile = changelogTemplate.mustache
[DEBUG]   (f) untaggedName = Next Release
[DEBUG] -- end configuration --
[INFO] Extended variables:
[INFO] No output set, using file CHANGELOG.md
[DEBUG] About to parse: inline@7e3fb4f4
[DEBUG] Building AST
[DEBUG] Applying Mustache spec
[DEBUG] Creating templates
[DEBUG] file=/Users/.....<here are some files>
...
[DEBUG] file=/Users/joht/Repositories/git/showcase-quarkus-eventsourcing/.git/packed-refs, isRacyClean=false, read=2023-03-11 20:18:50.323458000, lastModified=2023-03-11 12:11:33.694667369, delta=29236628790631 ns, racy<=5000 ns
[DEBUG] file=/Users/joht/Repositories/git/showcase-quarkus-eventsourcing/.git/packed-refs, is unmodified
[DEBUG] Work left: 2
[DEBUG] Work left: 2
[DEBUG] Work left: 2
[DEBUG] Work left: 2
[DEBUG] Work left: 2
[DEBUG] Work left: 2
[DEBUG] Work left: 3
...

Workaround

Starting it with mvn changelog:changelog seems to work without any issues. If I use <skip>true</skip> within the configuration of the plugin it won't run during build anymore. So I can start both commands separately. Nevertheless this is not ideal.

Here is the output of this for comparison. There is much more going on within the configuration:

[DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-changelog-plugin:2.3:changelog' with basic configurator -->
[DEBUG]   (f) basedir = /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing
[DEBUG]   (f) connectionType = connection
[DEBUG]   (f) dateFormat = yyyy-MM-dd HH:mm:ss
[DEBUG]   (f) developers = []
[DEBUG]   (f) displayFileDetailUrl = https://github.com/JohT/showcase-quarkus-eventsourcing
[DEBUG]   (f) encodeFileUri = false
[DEBUG]   (f) headingDateFormat = yyyy-MM-dd
[DEBUG]   (f) issueIDRegexPattern = [a-zA-Z]{2,}-\d+
[DEBUG]   (f) issueLinkUrl = http://jira.codehaus.org/browse/%ISSUE%
[DEBUG]   (f) offline = false
[DEBUG]   (f) outputDirectory = /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing/target/site
[DEBUG]   (f) outputEncoding = UTF-8
[DEBUG]   (f) outputXML = /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing/target/changelog.xml
[DEBUG]   (f) outputXMLExpiration = 60
[DEBUG]   (f) range = -1
[DEBUG]   (f) scmUrl = https://github.com/JohT/showcase-quarkus-eventsourcing
[DEBUG]   (f) skip = false
[DEBUG]   (f) type = range
[DEBUG]   (f) project = MavenProject: io.github.joht.showcase.quarkuseventsourcing:showcase-quarkus-eventsourcing:2.0.1-SNAPSHOT @ /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing/pom.xml
[DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@14c93774
[DEBUG] -- end configuration --
[INFO] Generating changed sets xml to: /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing/target/changelog.xml
[INFO] Executing: /bin/sh -c cd /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing && git whatchanged '--since=2023-02-09 19:30:26 +0000' '--until=2023-03-12 19:30:26 +0000' --date=iso -- /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing
[INFO] Working directory: /Users/joht/Repositories/git/showcase-quarkus-eventsourcing/showcase-quarkus-eventsourcing

[tomasbjerre]

Thanks @JohT ! This algorithm is a mess... but I think I fixed it.

I was able to generate your changelog with:

npx git-changelog-command-line -t showcase-quarkus-eventsourcing/changelogTemplate.mustache -ut "Next Release" -of showcase-quarkus-eventsourcing/CHANGELOG.md

[JohT]

@tomasbjerre thank you so much for your time.

How can I "translate" the node command to maven? I was able to generate the changelog with mvn changelog:changelog (see my Workaround). I'm not sure why this works and what the difference is between running one plugin on its own (working) and running the whole build (not working).

If this is currently the way to do it, then I'll be fine with it.

[tomasbjerre]

I guess Maven does not pick up same configuration with those two commands, I don't know.

I found the issue while debugging a test case in this library where I point at your repository.

[JohT]

@tomasbjerre, the problem is solved at least on my side as far as I can see for now with Update dependency se.bjurr.gitchangelog:git-changelog-maven-plugin to v1.96.1. 🎉 Thank you very much. Well done.👏

[delanym]

@JohT use pluginManagement to configure the plugin without necessarily executing it (no need to skip)

@tomasbjerre I don't know what's changed, but the behaviour since 1.64 is still the same: out of lifecycle execution completes, while binding the execution to a phase in the default lifecycle gets stuck.

If changelog:changelog is going to be the only way, then the docs at git-changelog-maven-plugin need attention. Someone new is not going to find this ticket.

You might have luck bringing this issue up at dev@maven.apache.org

[tomasbjerre]

@delanym in the case of @JohT there was a logical bug in this library that actually resulted in infinite bug. Your comment sounds like there is also a bug with Maven. I would happily investigate that, but I would need a repository to reproduce it.

[delanym]

@JohT I failed to build your showcase-quarkus-eventsourcing repo. Do you still need to run changelog:changelog outside the default lifecycle?