fix: Upgrade to Lucene 10.x and fix API compatibility for record types (#14)

* Initial plan

* Fix Lucene 10.x API compatibility: use record accessor methods

In Lucene 10.x, TotalHits, BooleanClause, and BoostQuery are now Java records.
Direct field access and old getter methods must be replaced with record accessor methods:
- TotalHits.value -> TotalHits.value()
- BooleanClause.getQuery() -> BooleanClause.query()
- BooleanClause.getOccur() -> BooleanClause.occur()
- BoostQuery.getQuery() -> BoostQuery.query()
- BoostQuery.getBoost() -> BoostQuery.boost()

Fixes #7

Co-authored-by: unknowIfGuestInDream <[email protected]>

* Update to Lucene 10.x and Eclipse 2024-12

- Update target-platform.target to use Eclipse 2024-12 and Orbit 2024-12
- Update MANIFEST.MF to require Lucene 10.0.0+ and Java 21
- Update feature.xml to require Lucene 10.0.0+
- Keep Lucene 10.x API changes (record accessor methods)

Co-authored-by: unknowIfGuestInDream <[email protected]>

* Improve JDK

* feat: Improve target lucene

* Revert to Lucene 9.x API: Eclipse Orbit doesn't have Lucene 10.x yet

Lucene 10.x bundles are not available in Eclipse Orbit repositories yet.
Reverting all changes back to use Lucene 9.x API which is what's available
in Eclipse Orbit 2024-06.

The original runtime error reported by users is likely caused by running
Eclipse versions that bundle newer Lucene versions not yet officially
supported in Orbit.

Co-authored-by: unknowIfGuestInDream <[email protected]>

* Upgrade to Lucene 10.x, JDK 21, and Eclipse 2025-03

- Update target-platform.target to Eclipse 2025-03 and Orbit 2025-03
- Update MANIFEST.MF to require Lucene 10.0.0+ and Java 21
- Update feature.xml to require Lucene 10.0.0+
- Update Java source files to use Lucene 10.x record accessor methods:
  - TotalHits.value -> TotalHits.value()
  - BooleanClause.getQuery() -> BooleanClause.query()
  - BooleanClause.getOccur() -> BooleanClause.occur()
  - BoostQuery.getQuery() -> BoostQuery.query()
  - BoostQuery.getBoost() -> BoostQuery.boost()
- Update all workflow files to use Java 21
- Update Eclipse project settings for Java 21
- Update README to reflect new requirements

Co-authored-by: unknowIfGuestInDream <[email protected]>

* Fix BoostQuery API: use getQuery() and getBoost() instead of record accessors

BoostQuery is not a record in Lucene 10.x, unlike TotalHits and BooleanClause.
It still uses the traditional getter methods getQuery() and getBoost().

Co-authored-by: unknowIfGuestInDream <[email protected]>

* build: Prepare for 1.1.0

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: unknowIfGuestInDream <[email protected]>
Co-authored-by: 梦里不知身是客 <[email protected]>

Author: Copilot

.github/workflows/artifact.yml

@@ -9,10 +9,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v6
-    - name: Set up JDK 17
+    - name: Set up JDK 21
       uses: actions/setup-java@v5
       with:
-        java-version: '17'
+        java-version: '21'
         distribution: 'temurin'
         cache: maven
     - name: Set up Maven

.github/workflows/maven.yml

@@ -1,6 +1,3 @@
-# This workflow will build a Java project with Maven
-# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven
-
 name: Eclipse Tycho build with Maven
 
 on:
@@ -15,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        java: [ 17, 21 ]
+        java: [ 21 ]
     runs-on: ${{ matrix.os }} 
 
     steps:

.github/workflows/release-build-upload.yml

@@ -13,11 +13,11 @@ jobs:
         uses: actions/checkout@v6
 
       # 根据你的项目类型选择合适的构建工具，比如 Maven/Gradle/npm
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: '17'
+          java-version: '21'
       - name: Set up Maven
         uses: stCarolas/setup-maven@v5
         with:

.github/workflows/update-site.yml

@@ -11,11 +11,11 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v5
         with:
           distribution: temurin
-          java-version: 17
+          java-version: 21
 
       - name: Import GPG key
         env:

README.md

@@ -4,7 +4,14 @@ InstaSearch is an Eclipse IDE plug-in for performing quick and advanced search o
 
 Each file then can be previewed using few most matching and relevant lines. A double-click on the match leads to the matching line in the file.
 
-Now Support Eclipse 2024-06 and later, Mac OS X, Linux (with nautilus) and Windows.
+Because Eclipse 2024-06 through 2024-12 are built on Apache Lucene 9.10.0 or later,  
+plugin version 1.0.0 provides initial support for this Lucene version range.  
+* Apache Lucene 9.10.0+
+* JDK 17
+
+Starting from version 1.1.0, the plugin supports Eclipse 2025-03 and later, and upgrades its dependency to Apache Lucene 10.0.0 or later.  
+* Apache Lucene 10.0.0+
+* JDK 21
 
 ## Use  
 
@@ -70,7 +77,8 @@ mvn clean org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=2.0.0
 
 ## Install
 
-1. Add `https://raw.githubusercontent.com/tlcsdm/eclipse-instasearch/update_site/` as the upgrade location in Eclipse.
+1. For Eclipse 2024-06 ~ 2024-12, add `https://raw.githubusercontent.com/tlcsdm/eclipse-instasearch/update_site_2024/` as the upgrade location in Eclipse.  
+   For Eclipse 2025-03 and later, add `https://raw.githubusercontent.com/tlcsdm/eclipse-instasearch/update_site/` as the upgrade location in Eclipse.  
 2. Download from [Jenkins](https://jenkins.tlcsdm.com/job/eclipse-plugin/job/eclipse-instasearch)
 3. <table style="border: none;">
   <tbody>

features/com.tlcsdm.eclipse.instasearch.feature/feature.xml

@@ -2,7 +2,7 @@
 <feature
       id="com.tlcsdm.eclipse.instasearch.feature"
       label="%featureName"
-      version="1.0.0.qualifier"
+      version="1.1.0.qualifier"
       provider-name="%providerName"
       plugin="com.tlcsdm.eclipse.instasearch">
 
@@ -303,16 +303,16 @@ version(s), and exceptions or additional permissions here}.&quot;
    <requires>
       <import plugin="org.eclipse.core.runtime" version="3.5.0" match="greaterOrEqual"/>
       <import plugin="org.eclipse.ui" version="3.5.0" match="greaterOrEqual"/>
-      <import plugin="org.apache.lucene.core" version="9.10.0" match="greaterOrEqual"/>
-      <import plugin="org.apache.lucene.analysis-common" version="9.10.0" match="greaterOrEqual"/>
+      <import plugin="org.apache.lucene.core" version="10.0.0" match="greaterOrEqual"/>
+      <import plugin="org.apache.lucene.analysis-common" version="10.0.0" match="greaterOrEqual"/>
       <import plugin="org.eclipse.ui.ide"/>
       <import plugin="org.eclipse.ui.editors"/>
       <import plugin="org.eclipse.ui.workbench.texteditor"/>
       <import plugin="org.eclipse.core.resources"/>
       <import plugin="org.eclipse.search"/>
       <import plugin="org.eclipse.jface.text"/>
       <import plugin="org.eclipse.debug.ui"/>
-      <import plugin="org.apache.lucene.queryparser" version="9.10.0" match="greaterOrEqual"/>
+      <import plugin="org.apache.lucene.queryparser" version="10.0.0" match="greaterOrEqual"/>
       <import plugin="org.apache.commons.lang3"/>
    </requires>
 

plugins/com.tlcsdm.eclipse.instasearch/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="output" path="bin"/>

plugins/com.tlcsdm.eclipse.instasearch/.settings/org.eclipse.jdt.core.prefs

@@ -1,10 +1,10 @@
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
-org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
-org.eclipse.jdt.core.compiler.compliance=17
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=21
+org.eclipse.jdt.core.compiler.compliance=21
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
 org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
 org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
 org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=warning
 org.eclipse.jdt.core.compiler.release=enabled
-org.eclipse.jdt.core.compiler.source=17
+org.eclipse.jdt.core.compiler.source=21

plugins/com.tlcsdm.eclipse.instasearch/META-INF/MANIFEST.MF

@@ -3,13 +3,13 @@ Bundle-ManifestVersion: 2
 Automatic-Module-Name: com.tlcsdm.eclipse.instasearch
 Bundle-Name: %pluginName
 Bundle-SymbolicName: com.tlcsdm.eclipse.instasearch;singleton:=true
-Bundle-Version: 1.0.0.qualifier
+Bundle-Version: 1.1.0.qualifier
 Bundle-Activator: com.tlcsdm.eclipse.instasearch.InstaSearchPlugin
 Bundle-Vendor: %providerName
 Require-Bundle: org.eclipse.ui,
- org.apache.lucene.core;bundle-version="[9.10.0,1000.0.0)",
- org.apache.lucene.analysis-common;bundle-version="[9.10.0,1000.0.0)",
- org.apache.lucene.queryparser;bundle-version="[9.10.0,1000.0.0)",
+ org.apache.lucene.core;bundle-version="[10.0.0,1000.0.0)",
+ org.apache.lucene.analysis-common;bundle-version="[10.0.0,1000.0.0)",
+ org.apache.lucene.queryparser;bundle-version="[10.0.0,1000.0.0)",
  org.apache.commons.lang3,
  org.eclipse.ui.ide,
  org.eclipse.ui.editors,
@@ -24,5 +24,5 @@ Require-Bundle: org.eclipse.ui,
  org.junit;resolution:=optional
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
-Bundle-RequiredExecutionEnvironment: JavaSE-17
+Bundle-RequiredExecutionEnvironment: JavaSE-21
 Bundle-DocURL: https://github.com/tlcsdm/eclipse-instasearch

plugins/com.tlcsdm.eclipse.instasearch/src/com/tlcsdm/eclipse/instasearch/indexing/Searcher.java

@@ -169,7 +169,7 @@ private SearchResult collectSearchResults(SearchQuery searchQuery, IndexSearcher
 		// Use IndexSearcher.search to get TopDocs
 		TopDocs topDocs = indexSearcher.search(query, maxResults);
 
-		if (topDocs.totalHits.value == 0)
+		if (topDocs.totalHits.value() == 0)
 			return null;
 
 		ScoreDoc[] hits = topDocs.scoreDocs;