Migrated GenreListFragment to Compose

Note: This is done on the back of some really great work by rivaldi8

Author: timusus

.github/workflows/continuous-integration.yml

@@ -55,7 +55,7 @@ jobs:
         run: "support/scripts/unit-test"
 
       - name: "Unit Test Results"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
           name: test-results

.github/workflows/continuous_deployment.yml

@@ -46,7 +46,7 @@ jobs:
         run: "support/scripts/unit-test"
 
       - name: "Unit Test Results"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
           name: test-results
@@ -61,7 +61,7 @@ jobs:
           CONFIGURATION: Release
 
       - name: "Upload App Bundle"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: app-bundle
           path: |

.idea/detekt.xml

@@ -8,6 +8,7 @@ plugins {
     id("com.google.firebase.crashlytics")
     id("com.google.devtools.ksp")
     alias(libs.plugins.compose.compiler)
+    alias(libs.plugins.detekt)
 }
 
 android {
@@ -268,6 +269,10 @@ android {
         implementation(libs.androidx.work.runtime.ktx)
         implementation(libs.androidx.hilt.work)
         ksp(libs.androidx.hilt.compiler)
+
+        detektPlugins(libs.detekt.formatting)
+
+        lintChecks(libs.compose.lint.checks)
     }
 
     buildFeatures.buildConfig = true

.idea/inspectionProfiles/Project_Default.xml

@@ -6,10 +6,10 @@
     android:layout_height="match_parent"
     android:fitsSystemWindows="true">
 
-    <androidx.drawerlayout.widget.DrawerLayout
-        android:id="@+id/drawer_layout"
-        android:layout_width="match_parent"
-        android:layout_height="match_parent">
+<!--    <androidx.drawerlayout.widget.DrawerLayout-->
+<!--        android:id="@+id/drawer_layout"-->
+<!--        android:layout_width="match_parent"-->
+<!--        android:layout_height="match_parent">-->
 
         <androidx.fragment.app.FragmentContainerView
             android:id="@+id/onboardingNavHostFragment"
@@ -18,23 +18,23 @@
             android:layout_height="match_parent"
             app:defaultNavHost="true" />
 
-        <com.google.android.material.navigation.NavigationView
-            android:id="@+id/nav_view"
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:layout_gravity="end"
-            android:background="?android:attr/windowBackground"
-            android:fitsSystemWindows="true">
+<!--        <com.google.android.material.navigation.NavigationView-->
+<!--            android:id="@+id/nav_view"-->
+<!--            android:layout_width="match_parent"-->
+<!--            android:layout_height="match_parent"-->
+<!--            android:layout_gravity="end"-->
+<!--            android:background="?android:attr/windowBackground"-->
+<!--            android:fitsSystemWindows="true">-->
 
-            <androidx.fragment.app.FragmentContainerView
-                android:id="@+id/debugDrawerFragment"
-                android:name="com.simplecityapps.shuttle.ui.screens.debug.DebugDrawerFragment"
-                android:layout_width="match_parent"
-                android:layout_height="match_parent" />
+<!--            <androidx.fragment.app.FragmentContainerView-->
+<!--                android:id="@+id/debugDrawerFragment"-->
+<!--                android:name="com.simplecityapps.shuttle.ui.screens.debug.DebugDrawerFragment"-->
+<!--                android:layout_width="match_parent"-->
+<!--                android:layout_height="match_parent" />-->
 
-        </com.google.android.material.navigation.NavigationView>
+<!--        </com.google.android.material.navigation.NavigationView>-->
 
-    </androidx.drawerlayout.widget.DrawerLayout>
+<!--    </androidx.drawerlayout.widget.DrawerLayout>-->
 
     <com.simplecityapps.shuttle.ui.common.view.SnowfallView
         android:id="@+id/snowfallView"

android/app/build.gradle.kts

@@ -0,0 +1,49 @@
+package com.simplecityapps.shuttle.ui.screens.library.genres
+
+import androidx.compose.material3.DropdownMenu
+import androidx.compose.material3.DropdownMenuItem
+import androidx.compose.material3.Text
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
+import com.simplecityapps.shuttle.R
+import com.simplecityapps.shuttle.model.Genre
+import com.simplecityapps.shuttle.model.Playlist
+import com.simplecityapps.shuttle.ui.screens.playlistmenu.PlaylistData
+
+@Composable
+fun AddToPlaylistSubmenu(
+    modifier: Modifier = Modifier,
+    genre: Genre,
+    expanded: Boolean = false,
+    onDismiss: () -> Unit = {},
+    playlists: List<Playlist>,
+    onAddToPlaylist: (playlist: Playlist, playlistData: PlaylistData) -> Unit,
+    onShowCreatePlaylistDialog: (genre: Genre) -> Unit
+) {
+    val playlistData = PlaylistData.Genres(genre)
+
+    DropdownMenu(
+        modifier = modifier,
+        expanded = expanded,
+        onDismissRequest = onDismiss
+    ) {
+        DropdownMenuItem(
+            text = { Text(stringResource(id = R.string.playlist_menu_create_playlist)) },
+            onClick = {
+                onShowCreatePlaylistDialog(genre)
+                onDismiss()
+            }
+        )
+
+        for (playlist in playlists) {
+            DropdownMenuItem(
+                text = { Text(playlist.name) },
+                onClick = {
+                    onAddToPlaylist(playlist, playlistData)
+                    onDismiss()
+                }
+            )
+        }
+    }
+}