add unit test, apparently \\ is only required for one element with commas

Author: SkyFi Geek

codegens/routeros-fetch/lib/index.js

@@ -138,12 +138,12 @@ function convert (request, options, callback) {
     if (header.includes('%') || header.includes(',')) {
       errors.push(`* Special characters in headers have many interpretations, check escaping - ${header} `);
     }
-    if (header.includes(',')) {
-      header = header.replace(/[,]/g, '\\,');
-    }
     return utils.escapeRouterOSString(header);
   });
   if (headers.length === 1) {
+    if (headers[0].includes(',')) {
+      headers[0] = headers[0].replace(/[,]/g, '\\\\,');
+    }
     attrs.set('http-header-field', headers[0]);
   }
   else if (headers.length > 1) {

codegens/routeros-fetch/test/unit/converter.test.js

@@ -91,7 +91,7 @@ describe('Converter test', function () {
     );
   });
 
-  it('should escape commas in headers', function () {
+  it('should escape commas in one header', function () {
     var request = new Request({
       method: 'GET',
       header: [
@@ -120,6 +120,41 @@ describe('Converter test', function () {
     );
   });
 
+  it('should NOT escape commas in one header', function () {
+    var request = new Request({
+      method: 'GET',
+      header: [
+        {
+          key: 'Commas',
+          value: 'a,1,2'
+        },
+        {
+          key: 'More',
+          value: 'x,y,z'
+
+        }
+      ],
+      url: {
+        raw: 'https://postman-echo.com/get',
+        protocol: 'https',
+        host: ['postman-echo', 'com'],
+        path: ['get']
+      }
+    });
+    convert(
+      request,
+      { style: 'plain', commentary: 'none' },
+      function (error, snippet) {
+        if (error) {
+          expect.fail(null, null, error);
+        }
+        console.log(snippet);
+        expect(snippet).to.contain('a,1,2');
+        expect(snippet).to.contain('x,y,z');
+      }
+    );
+  });
+
   it('should generate snippets(not error out) for requests with no body', function () {
     var request = new Request({
       method: 'GET',

package.json

@@ -1,6 +1,6 @@
 {
   "name": "postman-code-generators",
-  "version": "1.13.1",
+  "version": "1.13.2",
   "description": "Generates code snippets for a postman collection",
   "main": "index.js",
   "directories": {