Skip to content

Use cli::cli_abort() from vroom's C++ code #577

@jennybc

Description

@jennybc

We're already using cli::cli_warn() and I've just switched to cli::cli_abort() from the R side. This would be a nice, consistent upgrade re: vroom's errors.

vroom/src/vroom_errors.h

Lines 85 to 105 in f7b9e2d

void warn_for_errors() const {
if (!have_warned_ && rows_.size() > 0) {
have_warned_ = true;
// it is intentional that we aren't using cpp11::package
// https://github.com/tidyverse/vroom/commit/984a3e5e37e124feacfec3d184dbeb02eb1145c4
SEXP cli_ns = Rf_findVarInFrame(R_NamespaceRegistry, Rf_install("cli"));
PROTECT(cli_ns);
SEXP cli_warn = Rf_findFun(Rf_install("cli_warn"), cli_ns);
PROTECT(cli_warn);
cpp11::strings bullets({
"w"_nm = "One or more parsing issues, call {.fun problems} on your data frame for details, e.g.:",
" "_nm = "dat <- vroom(...)",
" "_nm = "problems(dat)"});
cpp11::sexp cli_warn_call = Rf_lang3(
cli_warn,
bullets,
Rf_mkString("vroom_parse_issue"));
Rf_eval(cli_warn_call, R_EmptyEnv);
UNPROTECT(2);
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    upkeepmaintenance, infrastructure, and similar

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions