Merge pull request #32 from thelia-modules/fix/empty-row-index

zawaze · web-flow · commit 44b067526446 · 2025-10-28T12:05:40.000+01:00
fix: add group by in index product for empty rows
diff --git a/Config/module.xml b/Config/module.xml
@@ -13,7 +13,7 @@
         <language>en_US</language>
         <language>fr_FR</language>
     </languages>
-    <version>3.1.1</version>
+    <version>3.1.2</version>
     <authors>
         <author>
             <name>Nicolas Barbey</name>
diff --git a/Index/Product.php b/Index/Product.php
@@ -51,9 +51,8 @@ public function buildSqlQuery(int $itemId = null, string $locale = null): string
 
         if ($itemId) {
             $query .= ' AND product.id=' . $itemId;
-        } else {
-            $query .= ' GROUP BY product.id';
         }
+        $query .= ' GROUP BY product.id';
 
         return $query;
     }

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,8 @@ public function buildSqlQuery(int $itemId = null, string $locale = null): string`
`51`	`51`
`52`	`52`	`if ($itemId) {`
`53`	`53`	`$query .= ' AND product.id=' . $itemId;`
`54`		`- } else {`
`55`		`- $query .= ' GROUP BY product.id';`
`56`	`54`	`}`
	`55`	`+ $query .= ' GROUP BY product.id';`
`57`	`56`
`58`	`57`	`return $query;`
`59`	`58`	`}`