add [[nodiscard]] at various places

Author: thelfer

include/MGIS/Function/BasicLinearQuadratureSpace.hxx

@@ -90,8 +90,9 @@ namespace mgis::function {
       const size_type) noexcept;
 
   template <size_type N>
-  constexpr bool areEquivalent(const BasicLinearQuadratureSpace<N>&,
-                               const BasicLinearQuadratureSpace<N>&) noexcept;
+  [[nodiscard]] constexpr bool areEquivalent(
+      const BasicLinearQuadratureSpace<N>&,
+      const BasicLinearQuadratureSpace<N>&) noexcept;
 
 }  // end of namespace mgis::function
 

include/MGIS/Function/BasicLinearSpace.hxx

@@ -41,8 +41,8 @@ namespace mgis::function {
 
   constexpr size_type getSpaceSize(const BasicLinearSpace&) noexcept;
 
-  constexpr bool areEquivalent(const BasicLinearSpace&,
-                               const BasicLinearSpace&) noexcept;
+  [[nodiscard]] constexpr bool areEquivalent(const BasicLinearSpace&,
+                                             const BasicLinearSpace&) noexcept;
 
 }  // end of namespace mgis::function
 

include/MGIS/Function/Evaluator.hxx

@@ -25,9 +25,10 @@ namespace mgis::function {
    * \param[in] e1: first evaluator
    * \param[in] e2: second evaluator
    */
-  constexpr bool checkMatchingSpaces(AbstractErrorHandler&,
-                                     const EvaluatorConcept auto&,
-                                     const EvaluatorConcept auto&);
+  [[nodiscard]] constexpr bool checkMatchingSpaces(
+      AbstractErrorHandler&,
+      const EvaluatorConcept auto&,
+      const EvaluatorConcept auto&);
 
 }  // end of namespace mgis::function
 

include/MGIS/Function/EvaluatorConcept.hxx

@@ -242,7 +242,8 @@ namespace mgis::function {
      * the allocateWorkspace function
      */
     template <EvaluatorConcept EvaluatorType>
-    constexpr bool disambiguateCheck(AbstractErrorHandler&, const EvaluatorType&);
+    [[nodiscard]] constexpr bool disambiguateCheck(AbstractErrorHandler&,
+                                                   const EvaluatorType&);
     /*!
      * This helper function allows to disambiguate the call to
      * the allocateWorkspace function
@@ -254,7 +255,8 @@ namespace mgis::function {
      * the getNumberOfComponents function
      */
     template <EvaluatorConcept EvaluatorType>
-    constexpr mgis::size_type disambiguateGetNumberOfComponents(EvaluatorType&);
+    [[nodiscard]] constexpr mgis::size_type disambiguateGetNumberOfComponents(
+        EvaluatorType&);
 
     /*!
      * \brief number of components of a type when known at compile-time,

include/MGIS/Function/Function.hxx

@@ -77,7 +77,8 @@ namespace mgis::function {
   };
 
   //! \brief a simple helper function
-  constexpr bool has_dynamic_properties(const FunctionDataLayoutDescription&);
+  [[nodiscard]] constexpr bool has_dynamic_properties(
+      const FunctionDataLayoutDescription&);
 
   /*!
    * \brief a simple data structure describing how the data of a

include/MGIS/Function/SharedSpace.hxx

@@ -139,31 +139,32 @@ namespace mgis::function {
   };
 
   template <SpaceConcept SpaceType>
-  bool areEquivalent(const SharedSpace<SpaceType>& s,
-                     const SharedSpace<SpaceType>& s2) noexcept {
+  [[nodiscard]] bool areEquivalent(const SharedSpace<SpaceType>& s,
+                                   const SharedSpace<SpaceType>& s2) noexcept {
     return s.get() == s2.get();
   }
 
   template <SpaceConcept SpaceType>
-  auto getSpaceSize(const SharedSpace<SpaceType>& s) {
+  [[nodiscard]] auto getSpaceSize(const SharedSpace<SpaceType>& s) {
     return getSpaceSize(*s);
   }
 
   template <QuadratureSpaceConcept SpaceType>
-  auto getNumberOfCells(const SharedSpace<SpaceType>& s) {
+  [[nodiscard]] auto getNumberOfCells(const SharedSpace<SpaceType>& s) {
     return getNumberOfCells(*s);
   }
 
   template <QuadratureSpaceConcept SpaceType>
-  auto getNumberOfQuadraturePoints(const SharedSpace<SpaceType>& s,
-                                   const cell_index<SpaceType>& e) {
+  [[nodiscard]] auto getNumberOfQuadraturePoints(
+      const SharedSpace<SpaceType>& s, const cell_index<SpaceType>& e) {
     return getNumberOfQuadraturePoints(*s, e);
   }
 
   template <LinearQuadratureSpaceConcept SpaceType>
-  auto getQuadraturePointOffset(const SharedSpace<SpaceType>& s,
-                                const cell_index<SpaceType>& e,
-                                const quadrature_point_index<SpaceType>& i) {
+  [[nodiscard]] auto getQuadraturePointOffset(
+      const SharedSpace<SpaceType>& s,
+      const cell_index<SpaceType>& e,
+      const quadrature_point_index<SpaceType>& i) {
     return getQuadraturePointOffset(*s, e, i);
   }