More erroneous inflections

[Ian-07]

Some of these may need to be fixed on Wiktionary itself:

• automatic has "dubious" as one of its forms
• bump has "Lighter" as one of its verb forms (at least, in the raw JSON data it does), resulting from one of its definitions on Wiktionary containing a reference
• grind has "glossary", "strong", and "no-table-tags" as some of its verb forms
• sit has "dated" as one of its forms
• sulfonamide has "spelling" as one of its forms
• unaccountability and uncountability both have "uncountable" as one of their forms. Maybe related to "Martinize" -> "participle Martinizing" and "participle Martinized" #938?

[kristian-clausal]

The fix in the PR should take care of most of these, but in case something doesn't get fixed or if you find other examples that didn't get fixed, please keep us posted; I think we can leave this thread open until then.

[xxyzz]

That pr only fix the "bump" page, sadly other pages are not affected.

[kristian-clausal]

    {
      "form": "no-table-tags",
      "source": "conjugation",
      "tags": [
        "table-tags"
      ]
    }

This is actually a meta-data kludge. "form" contains table-specific "tags" (could be ids and stuff like that, iirc), and the tag table-tags marks that this form entry should be ignored as a form.

[kristian-clausal]

Same for

    {
      "form": "glossary",
      "source": "conjugation",
      "tags": [
        "inflection-template"
      ]
    }

this form-of-entry just shows the break between two templates (or tables).

[kristian-clausal]

I don't know why dated is a table-tags entry (like above), though, I'll try to figure it out.

[kristian-clausal]

For some reason the code is trying to parse the first data-containing line of the table in sit (starting with "1st person...") as a title, so we have a bug.

[kristian-clausal]

Oh noo, I just realized what was wrong.

Template:en-conj mixes wikitext tables and <td> elements. That's fine for wikitext, both of those get "expanded" into HTML anyhow, but our more abstract parse tree sees those <td> elements and puts them inside the Table Cell node.

This template has used <td> elements like this for years now, I don't know why it hasn't come up yet.

The code in en/inflextion.py for this is a mess. The last time I had to crawl through and understand it, I left whole books of comments in there to remind me next time what was actually happening in the code, and I have genuine trouble understanding my own comments explaining what is happening.

[kristian-clausal]

Some of these should be fixed now. The bug turned out to be a... well. We parse wikitext table cells and HTML cells as "different" things. But Wikitext is ultimately a templating language, and both of them ultimately expand into HTML, so mixing Wikitext and HTML entities doesn't matter there.

Except our parser makes the wikitext cell eat its TD-element siblings in this case.

TD-elements are used in these complex Wikitables because (I assume) it's handier to write a <td> inside a complex {{#if....

The fix just 'corrects' this error in our parse tree by checking if a Wikitext table header or cell has direct td-child elements and yields them as separate cells into the normal for loop.