Merge pull request #384 from xxyzz/padleft

Fix `ZeroDivisionError` exception in `padleft_fn`

Author: kristian-clausal

src/wikitextprocessor/parserfns.py

@@ -1037,7 +1037,7 @@ def padleft_fn(
     """Implements the padleft parser function."""
     v = expander(args[0]) if args else ""
     cntstr = expander(args[1]).strip() if len(args) >= 2 else "0"
-    pad = expander(args[2]) if len(args) >= 3 and args[2] else "0"
+    pad = expander(args[2]) if len(args) >= 3 else "0"
     if not cntstr.isdigit():
         if cntstr.startswith("-") and cntstr[1:].isdigit():
             pass
@@ -1049,7 +1049,7 @@ def padleft_fn(
         cnt = 0
     else:
         cnt = int(cntstr)
-    if cnt - len(v) > len(pad):
+    if cnt - len(v) > len(pad) and len(pad) > 0:
         pad = pad * ((cnt - len(v)) // len(pad))
     if len(v) < cnt:
         v = pad[: cnt - len(v)] + v

tests/test_parserfns.py

@@ -207,3 +207,10 @@ def test_int(self):
         self.wtp.project = "wikipedia"
         self.assertEqual(self.wtp.expand("{{int:lang}}"), "⧼lang⧽")
         self.assertEqual(self.wtp.expand("{{int:}}"), "[[:Template:int:]]")
+
+    def test_padleft_zero_division(self):
+        # https://en.wiktionary.org/wiki/land
+        # https://en.wiktionary.org/wiki/Template:R:osx:Kobler
+        self.wtp.start_page("land")
+        self.assertEqual(self.wtp.expand("{{padleft:|1|}}"), "")
+        self.assertEqual(self.wtp.expand("{{padleft:|1}}"), "0")