⚡️ Improve performance of DataFixtures (#963)

Author: 0x46616c6b

src/DataFixtures/LoadRandomAliasData.php

@@ -9,6 +9,7 @@
 use Doctrine\Bundle\FixturesBundle\Fixture;
 use Doctrine\Bundle\FixturesBundle\FixtureGroupInterface;
 use Doctrine\Common\DataFixtures\DependentFixtureInterface;
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\Persistence\ObjectManager;
 use Override;
 
@@ -17,23 +18,31 @@ final class LoadRandomAliasData extends Fixture implements FixtureGroupInterface
     #[Override]
     public function load(ObjectManager $manager): void
     {
+        assert($manager instanceof EntityManagerInterface);
+
         $user = $manager->getRepository(User::class)->findByEmail('[email protected]');
 
         for ($i = 1; $i < 5; ++$i) {
             $alias = AliasFactory::create($user, null);
-
             $manager->persist($alias);
         }
+        $manager->flush();
 
-        $users = $manager->getRepository(User::class)->findAll();
+        $userIds = $manager->getRepository(User::class)->createQueryBuilder('u')
+            ->select('u.id')
+            ->getQuery()
+            ->getSingleColumnResult();
 
         for ($i = 1; $i < 500; ++$i) {
-            $alias = AliasFactory::create($users[random_int(0, count($users) - 1)], 'alias'.$i);
+            $userId = $userIds[array_rand($userIds)];
+            $user = $manager->getReference(User::class, $userId);
+            $alias = AliasFactory::create($user, 'alias'.$i);
 
             $manager->persist($alias);
 
-            if (($i % 100) === 0) {
+            if (($i % 250) === 0) {
                 $manager->flush();
+                $manager->clear();
             }
         }
 

src/DataFixtures/LoadRandomUserData.php

@@ -13,17 +13,16 @@
 
 final class LoadRandomUserData extends AbstractUserData implements FixtureGroupInterface
 {
+    private const BATCH_SIZE = 500;
+
     #[Override]
     public function load(ObjectManager $manager): void
     {
-        $domainRepository = $manager->getRepository(Domain::class);
-        $domain = $domainRepository->findOneBy(['name' => 'example.org']);
+        $domain = $manager->getRepository(Domain::class)->findOneBy(['name' => 'example.org']);
         $roles = [Roles::USER];
 
         for ($i = 0; $i < 15000; ++$i) {
-            $email = sprintf('user-%d@%s', $i, $domain->getName());
-
-            $user = $this->buildUser($domain, $email, $roles);
+            $user = $this->buildUser($domain, sprintf('user-%d@%s', $i, $domain->getName()), $roles);
             $user->setCreationTime(new DateTime(sprintf('-%s days', random_int(1, 25))));
 
             if (0 === $i % 20) {
@@ -36,8 +35,11 @@ public function load(ObjectManager $manager): void
 
             $manager->persist($user);
 
-            if (($i % 100) === 0) {
+            if (($i % self::BATCH_SIZE) === 0) {
                 $manager->flush();
+                $manager->clear();
+                // Re-fetch domain after clear
+                $domain = $manager->getRepository(Domain::class)->findOneBy(['name' => 'example.org']);
             }
         }
 

src/DataFixtures/LoadReservedNameData.php

@@ -4,25 +4,14 @@
 
 namespace App\DataFixtures;
 
-use App\Creator\ReservedNameCreator;
-use App\Exception\ValidationException;
+use App\Factory\ReservedNameFactory;
 use Doctrine\Bundle\FixturesBundle\Fixture;
 use Doctrine\Bundle\FixturesBundle\FixtureGroupInterface;
 use Doctrine\Persistence\ObjectManager;
 use Override;
 
 final class LoadReservedNameData extends Fixture implements FixtureGroupInterface
 {
-    /**
-     * LoadReservedNameData constructor.
-     */
-    public function __construct(private readonly ReservedNameCreator $creator)
-    {
-    }
-
-    /**
-     * @throws ValidationException
-     */
     #[Override]
     public function load(ObjectManager $manager): void
     {
@@ -31,19 +20,26 @@ public function load(ObjectManager $manager): void
             'r'
         );
 
+        $count = 0;
         while ($line = fgets($handle)) {
             $name = trim($line);
-            if (empty($name)) {
+            if (empty($name) || '#' === $name[0]) {
                 continue;
             }
 
-            if ('#' === $name[0]) {
-                // filter out comments
-                continue;
-            }
+            $reservedName = ReservedNameFactory::create($name);
+            $manager->persist($reservedName);
+            ++$count;
 
-            $this->creator->create($name);
+            if (($count % 250) === 0) {
+                $manager->flush();
+                $manager->clear();
+            }
         }
+
+        fclose($handle);
+        $manager->flush();
+        $manager->clear();
     }
 
     #[Override]

src/DataFixtures/LoadVoucherData.php

@@ -10,6 +10,7 @@
 use Doctrine\Bundle\FixturesBundle\Fixture;
 use Doctrine\Bundle\FixturesBundle\FixtureGroupInterface;
 use Doctrine\Common\DataFixtures\DependentFixtureInterface;
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\Persistence\ObjectManager;
 use Exception;
 use Override;
@@ -22,12 +23,21 @@ final class LoadVoucherData extends Fixture implements FixtureGroupInterface, De
     #[Override]
     public function load(ObjectManager $manager): void
     {
-        $users = $manager->getRepository(User::class)->findAll();
+        assert($manager instanceof EntityManagerInterface);
+
+        $userIds = $manager->getRepository(User::class)->createQueryBuilder('u')
+            ->select('u.id')
+            ->getQuery()
+            ->getSingleColumnResult();
+
+        $suspiciousUser = $manager->getRepository(User::class)->findByEmail('[email protected]');
+        $suspiciousUserId = $suspiciousUser->getId();
 
         for ($i = 0; $i < 1000; ++$i) {
-            $voucher = VoucherFactory::create($users[random_int(1, count($users) - 1)]);
+            $user = $manager->getReference(User::class, $userIds[array_rand($userIds)]);
+            $voucher = VoucherFactory::create($user);
 
-            $invitedUser = $users[random_int(0, count($users) - 1)];
+            $invitedUser = $manager->getReference(User::class, $userIds[array_rand($userIds)]);
             $voucher->setInvitedUser($invitedUser);
             $voucher->setRedeemedTime(new DateTime());
 
@@ -39,15 +49,16 @@ public function load(ObjectManager $manager): void
 
             $manager->persist($voucher);
 
-            if (($i % 100) === 0) {
+            if (($i % 250) === 0) {
                 $manager->flush();
+                $manager->clear();
             }
         }
 
         // add redeemed voucher to a suspicious parent
-        $user = $manager->getRepository(User::class)->findByEmail('[email protected]');
+        $user = $manager->getReference(User::class, $suspiciousUserId);
         $voucher = VoucherFactory::create($user);
-        $invitedUser = $users[random_int(0, count($users) - 1)];
+        $invitedUser = $manager->getReference(User::class, $userIds[array_rand($userIds)]);
         $voucher->setInvitedUser($invitedUser);
         $voucher->setRedeemedTime(new DateTime(sprintf('-%d days', 100)));