Merge branch 'main' into main

Author: kdy1

.github/workflows/binary-size-comment.yml

@@ -0,0 +1,51 @@
+name: Binary Size Check - Comment
+
+on:
+  workflow_run:
+    workflows: ["Binary Size Check - Build"]
+    types:
+      - completed
+
+env:
+  CI: 1
+
+jobs:
+  comment-on-pr:
+    name: Comment on PR
+    runs-on: ubuntu-latest
+    # This workflow needs write permissions to comment on PRs
+    # It's safe because it doesn't execute any code from the PR
+    permissions:
+      pull-requests: write
+      contents: read
+    # Only run on successful builds
+    if: github.event.workflow_run.conclusion == 'success'
+    steps:
+      - name: Download artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: size-report
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event.workflow_run.id }}
+
+      - name: Read PR number
+        id: pr
+        run: |
+          PR_NUMBER=$(cat pr_number.txt)
+          echo "number=$PR_NUMBER" >> $GITHUB_OUTPUT
+
+      - name: Find existing comment
+        uses: peter-evans/find-comment@v3
+        id: find-comment
+        with:
+          issue-number: ${{ steps.pr.outputs.number }}
+          comment-author: "github-actions[bot]"
+          body-includes: "## Binary Sizes"
+
+      - name: Create or update PR comment
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          comment-id: ${{ steps.find-comment.outputs.comment-id }}
+          issue-number: ${{ steps.pr.outputs.number }}
+          body-path: size_report.md
+          edit-mode: replace

.github/workflows/binary-size.yml

@@ -1,12 +1,8 @@
-name: Binary Size Check
+name: Binary Size Check - Build
 
 on:
   pull_request:
     types: ["opened", "reopened", "synchronize"]
-  # Disable push events for now because of the permission issue
-  # push:
-  #   branches:
-  #     - main
 
 env:
   CI: 1
@@ -23,8 +19,8 @@ jobs:
   measure-binary-size:
     name: Measure Binary Size
     runs-on: ubuntu-latest
+    # No special permissions needed - this workflow only reads and uploads artifacts
     permissions:
-      pull-requests: write
       contents: read
     steps:
       - uses: actions/checkout@v4
@@ -77,56 +73,15 @@ jobs:
           echo "" >> size_report.md
           echo "*Commit: ${{ github.sha }}*" >> size_report.md
 
-      - name: Find existing comment
-        if: github.event_name == 'pull_request'
-        uses: peter-evans/find-comment@v3
-        id: find-comment
-        with:
-          issue-number: ${{ github.event.pull_request.number }}
-          comment-author: "github-actions[bot]"
-          body-includes: "## Binary Sizes"
+      - name: Save PR number
+        run: |
+          echo "${{ github.event.pull_request.number }}" > pr_number.txt
 
-      - name: Create or update PR comment
-        if: github.event_name == 'pull_request'
-        uses: peter-evans/create-or-update-comment@v4
+      - name: Upload size report and PR info
+        uses: actions/upload-artifact@v4
         with:
-          comment-id: ${{ steps.find-comment.outputs.comment-id }}
-          issue-number: ${{ github.event.pull_request.number }}
-          body-path: size_report.md
-          edit-mode: replace
-
-      - name: Find existing commit comment
-        if: github.event_name == 'push'
-        id: find-commit-comment
-        run: |
-          COMMENTS=$(gh api repos/${{ github.repository }}/commits/${{ github.sha }}/comments \
-            --jq '.[] | select(.body | contains("## Binary Sizes")) | .id' | head -n 1)
-
-          if [ -n "$COMMENTS" ]; then
-            echo "comment_id=$COMMENTS" >> $GITHUB_OUTPUT
-          else
-            echo "comment_id=" >> $GITHUB_OUTPUT
-          fi
-        env:
-          GH_TOKEN: ${{ github.token }}
-
-      - name: Create or update commit comment
-        if: github.event_name == 'push'
-        run: |
-          BODY=$(cat size_report.md)
-
-          if [ -n "${{ steps.find-commit-comment.outputs.comment_id }}" ]; then
-            gh api \
-              --method PATCH \
-              -H "Accept: application/vnd.github+json" \
-              repos/${{ github.repository }}/comments/${{ steps.find-commit-comment.outputs.comment_id }} \
-              -f body="$BODY"
-          else
-            gh api \
-              --method POST \
-              -H "Accept: application/vnd.github+json" \
-              repos/${{ github.repository }}/commits/${{ github.sha }}/comments \
-              -f body="$BODY"
-          fi
-        env:
-          GH_TOKEN: ${{ github.token }}
+          name: size-report
+          path: |
+            size_report.md
+            pr_number.txt
+          retention-days: 1