Fix temp and reconnect (#16)

* fix: update .gitignore

* feat: Add reconnect button functionality to Sharp AC component
fix:temp

---------

Co-authored-by: SvenH <[email protected]>

Author: sven819

.gitignore

@@ -1,4 +1,5 @@
 # Gitignore settings for ESPHome 
+# Gitignore settings for ESPHome 
 /.esphome/
 /secrets.yaml
 /logs/
@@ -14,3 +15,12 @@ tests/*.o
 tests/test_frame_parsing
 tests/test_core_logic
 tests/test_integration
+wohnzimmer.yaml
+ota.yaml
+**/node_modules/
+
+# C++ Unit Test artifacts
+tests/*.o
+tests/test_frame_parsing
+tests/test_core_logic
+tests/test_integration

components/sharp_ac/climate.py

@@ -1,9 +1,9 @@
 import esphome.codegen as cg
 import esphome.config_validation as cv
-from esphome.components import climate, uart, select, switch, text_sensor
+from esphome.components import climate, uart, select, switch, text_sensor, button
 from esphome.const import CONF_ID
 
-AUTO_LOAD = ["climate", "uart", "select", "switch", "text_sensor"]
+AUTO_LOAD = ["climate", "uart", "select", "switch", "text_sensor", "button"]
 CODEOWNERS = ["@sven819"]
 
 CONF_SHARP_ID = "sharp_id"
@@ -16,11 +16,13 @@
 
 IonSwitch = sharp_ac_ns.class_("IonSwitch", switch.Switch)
 ConnectionStatusSensor = sharp_ac_ns.class_("ConnectionStatusSensor", text_sensor.TextSensor, cg.Component)
+ReconnectButton = sharp_ac_ns.class_("ReconnectButton", button.Button, cg.Component)
 
 CONF_HORIZONTAL_SWING_SELECT = "horizontal_vane_select"
 CONF_VERTICAL_SWING_SELECT = "vertical_vane_select"
 CONF_ION_SWITCH = "ion_switch"
 CONF_CONNECTION_STATUS = "connection_status"
+CONF_RECONNECT_BUTTON = "reconnect_button"
 
 HORIZONTAL_SWING_OPTIONS = ["swing","left","center","right"]
 VERTICAL_SWING_OPTIONS = ["auto", "swing" , "up" , "up_center", "center", "down_center", "down"]
@@ -45,13 +47,18 @@
     {cv.GenerateID(CONF_ID): cv.declare_id(ConnectionStatusSensor)}
 )
 
+RECONNECT_BUTTON_SCHEMA = button.button_schema(ReconnectButton).extend(
+    {cv.GenerateID(CONF_ID): cv.declare_id(ReconnectButton)}
+)
+
 CONFIG_SCHEMA = climate.climate_schema(SharpAc).extend(
     {
         cv.GenerateID(): cv.declare_id(SharpAc),
         cv.Optional(CONF_HORIZONTAL_SWING_SELECT): SELECT_SCHEMA_HORIZONTAL,
         cv.Optional(CONF_VERTICAL_SWING_SELECT): SELECT_SCHEMA_VERTICAL,
         cv.Optional(CONF_ION_SWITCH): ION_SCHEMA,
-        cv.Optional(CONF_CONNECTION_STATUS): CONNECTION_STATUS_SCHEMA
+        cv.Optional(CONF_CONNECTION_STATUS): CONNECTION_STATUS_SCHEMA,
+        cv.Optional(CONF_RECONNECT_BUTTON): RECONNECT_BUTTON_SCHEMA
     }
 ).extend(uart.UART_DEVICE_SCHEMA)
 
@@ -82,6 +89,13 @@ async def to_code(config):
         cg.add(var.setConnectionStatusSensor(sens))
         await cg.register_parented(sens, var)
 
+    if CONF_RECONNECT_BUTTON in config:
+        conf = config[CONF_RECONNECT_BUTTON]
+        btn = await button.new_button(conf)
+        cg.add(btn.set_parent(var))
+        cg.add(var.setReconnectButton(btn))
+        await cg.register_parented(btn, var)
+
     await uart.register_uart_device(var, config)
     await climate.register_climate(var, config)
     await cg.register_component(var, config)

components/sharp_ac/comp_hardware.cpp

@@ -1,6 +1,7 @@
 #include "comp_hardware.h"
 #include "comp_vane_horizontal.h"
 #include "comp_vane_vertical.h"
+#include "comp_reconnect_button.h"
 
 namespace esphome
 {
@@ -343,5 +344,23 @@ namespace esphome
       connectionStatusSensor->publish_state(status_text);
     }
 
+    void SharpAc::triggerReconnect()
+    {
+      ESP_LOGI("sharp_ac", "Triggering connection reset...");
+      if (core_)
+      {
+        core_->resetConnection();
+      }
+    }
+
+    void ReconnectButton::press_action()
+    {
+      ESP_LOGI("sharp_ac", "Reconnect button pressed - resetting connection");
+      if (this->parent_ != nullptr)
+      {
+        this->parent_->triggerReconnect();
+      }
+    }
+
   }
 }

components/sharp_ac/comp_hardware.h

@@ -5,6 +5,7 @@
 #include "esphome/components/switch/switch.h"
 #include "esphome/components/select/select.h"
 #include "esphome/components/text_sensor/text_sensor.h"
+#include "esphome/components/button/button.h"
 #include "esphome/core/log.h"
 #include "esphome/core/helpers.h"
 
@@ -32,6 +33,7 @@ namespace esphome
     class VaneSelectVertical;
     class VaneSelectHorizontal;
     class ConnectionStatusSensor;
+    class ReconnectButton;
     class SharpAc; 
 
     class ESPHomeHardwareInterface : public SharpAcHardwareInterface {
@@ -124,7 +126,13 @@ namespace esphome
         this->connectionStatusSensor = sensor;
       };
 
+      void setReconnectButton(button::Button *button)
+      {
+        this->reconnectButton = button;
+      };
+
       void updateConnectionStatus(int status);
+      void triggerReconnect();
 
     private:
       std::unique_ptr<ESPHomeHardwareInterface> hardware_interface_;
@@ -135,6 +143,7 @@ namespace esphome
       VaneSelectVertical *vaneVertical;
       VaneSelectHorizontal *vaneHorizontal;
       text_sensor::TextSensor *connectionStatusSensor{nullptr};
+      button::Button *reconnectButton{nullptr};
     };
   }
 }

components/sharp_ac/comp_reconnect_button.h

@@ -0,0 +1,23 @@
+#pragma once
+
+#include "esphome/components/button/button.h"
+#include "esphome/core/component.h"
+
+namespace esphome
+{
+  namespace sharp_ac
+  {
+    class SharpAc;
+
+    class ReconnectButton : public button::Button, public Component
+    {
+    public:
+      void set_parent(SharpAc *parent) { this->parent_ = parent; }
+
+    protected:
+      void press_action() override;
+      SharpAc *parent_{nullptr};
+    };
+
+  } 
+}

components/sharp_ac/core_frame.cpp

@@ -82,7 +82,7 @@ SharpStatusFrame::SharpStatusFrame(const uint8_t *arr) : SharpFrame(arr, 18)
 
 int SharpStatusFrame::getTemperature()
 {
-    return (this->data[7] & 0x0F) + 16;
+    return this->data[7];
 }
 
 SharpModeFrame::SharpModeFrame(const uint8_t *arr) : SharpFrame(arr, 14)

components/sharp_ac/core_logic.h

@@ -60,6 +60,7 @@ namespace esphome
       void controlSwing(SwingHorizontal h, SwingVertical v);
       void controlTemperature(int temperature);
       void controlPreset(Preset preset);
+      void resetConnection();
 
     protected:
       std::string analyzeByte(uint8_t byte, size_t position, bool isStatusFrame);
@@ -96,7 +97,6 @@ namespace esphome
       void processUpdate(SharpFrame &frame);
       void startInit();
       void checkTimeout();
-      void resetConnection();
       int status = 0;
       unsigned long connectionStart = 0;
       unsigned long previousMillis = 0;

klima.yaml

@@ -40,4 +40,6 @@ climate:
     ion_switch:
       name: Plasmacluster
     connection_status:
-      name: "AC Connection Status"
+      name: "AC Connection Status"
+    reconnect_button:
+      name: "AC Reconnect"