Skip to content

🐛 BUG: Missing return statements after sending responses leads to request processing continuation #6

@GaneshPatil7517

Description

@GaneshPatil7517

Summary
Several controllers are missing return statements after sending error responses, causing the code to continue executing even after the response is sent. This can lead to unexpected behavior and potential server crashes.

Affected Files

  • src/controllers/editProject.ts - Line 10
  • src/controllers/forkProject.ts - Line 8
  • src/controllers/pullRequest.ts - Line 7

Current Behaviour

// [editProject.ts](http://_vscodecontentref_/0)
if (!commitMessage) {
    res.status(300).json({ message: "Commit message is required" });
}
await updateProjectDataFile(repoName, projectData, commitMessage); // Still executes!

Expected Behaviour

if (!commitMessage) {
    res.status(300).json({ message: "Commit message is required" });
    return; // Should stop execution
}

Impact
Potential duplicate responses
Server-side errors
Unpredictable API behaviour

Suggested Fix
Add return statements after all early response sends.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions