Non critical Error evaluation (Tproxy)

[Shourya742]

There are several instances in Tproxy where errors are considered non-critical and silently ignored. Even with the new contextual error mechanism, these cases are still only being logged and skipped. This issue is to review each of these paths and send patches where a better resolution strategy makes sense.

[plebhash]

while #132 is laying down some foundational systems for error handling, it's not realistic to review in-detail every single instance where this new system is being used on every single app at once... that was the motivation for creating this issue here, in the spirit of breaking things down in smaller steps

but I would propose the scope here should actually be much broader than originally described, also accounting for the re-evaluation of every error case.

if we restricted this task only on re-evaluating log-and-skip, while assuming that #132 has already correctly taken care of every other scenario, we are leaving too much room for loose ends and blindspots that will most likely come back to bite our asses in the future.

this should be an opportunity for a fine toothcomb review that makes correct usage of the foundations from #132 without leaving anything behind

---

TLDR: IMHO we should re-evaluate EVERYTHING that's making usage of #132 (as well as current usage of _ = , unwrap(), expect(), if let Err, if let Some, etc), not only non-critical or log-and-skip, as the original description and title suggest