Simplify cargo install error handling in tool scripts

Removed custom checks for 'already installed' errors in install-tools.ps1 and install-tools.sh. Now, any non-zero exit code from cargo install will cause the script to exit with an error, streamlining error handling. Updated deploy.yml to cache additional Cargo files for improved build performance.

Author: sean-parent

.github/workflows/deploy.yml

@@ -36,6 +36,8 @@ jobs:
             ~/.cargo/registry/index/
             ~/.cargo/registry/cache/
             ~/.cargo/git/db/
+            ~/.cargo/.crates.toml
+            ~/.cargo/.crates2.json
           key: ${{ runner.os }}-cargo-${{ hashFiles('versions.toml') }}
           restore-keys: |
             ${{ runner.os }}-cargo-

scripts/install-tools.ps1

@@ -53,21 +53,12 @@ function Get-MdbookPlugins {
 Write-Host "Reading versions from $VersionsFile..." -ForegroundColor Cyan
 
 # Install mdBook
-# Note: cargo install doesn't provide separate exit codes for "already installed" vs other errors
-# See: https://github.com/rust-lang/cargo/issues/11513
-# We check the error message as a workaround until cargo provides a better solution.
 $MdbookVersion = Get-ToolVersion -Tool "mdbook"
 if ($MdbookVersion) {
     Write-Host "`nInstalling mdBook $MdbookVersion..." -ForegroundColor Cyan
-    $output = cargo install mdbook --version $MdbookVersion 2>&1
+    cargo install mdbook --version $MdbookVersion
     if ($LASTEXITCODE -ne 0) {
-        # Check for "already installed" error - cargo uses different messages
-        if ($output -match "(?i)(already exists in destination|is already installed)") {
-            Write-Host "  (already installed)" -ForegroundColor Gray
-        } else {
-            Write-Host $output -ForegroundColor Red
-            exit 1
-        }
+        exit 1
     }
 } else {
     Write-Host "Error: Could not find mdbook version in versions.toml" -ForegroundColor Red
@@ -80,15 +71,9 @@ Write-Host "`nInstalling mdBook plugins..." -ForegroundColor Cyan
 $plugins = Get-MdbookPlugins
 foreach ($plugin in $plugins.GetEnumerator()) {
     Write-Host "Installing $($plugin.Key) $($plugin.Value)..." -ForegroundColor Cyan
-    $output = cargo install $plugin.Key --version $plugin.Value 2>&1
+    cargo install $plugin.Key --version $plugin.Value
     if ($LASTEXITCODE -ne 0) {
-        # Check for "already installed" error - cargo uses different messages
-        if ($output -match "(?i)(already exists in destination|is already installed)") {
-            Write-Host "  (already installed)" -ForegroundColor Gray
-        } else {
-            Write-Host $output -ForegroundColor Red
-            exit 1
-        }
+        exit 1
     }
 }
 

scripts/install-tools.sh

@@ -29,21 +29,10 @@ get_version() {
 echo "Reading versions from ${VERSIONS_FILE}..."
 
 # Install mdBook
-# Note: cargo install doesn't provide separate exit codes for "already installed" vs other errors
-# See: https://github.com/rust-lang/cargo/issues/11513
-# We check the error message as a workaround until cargo provides a better solution.
 MDBOOK_VERSION=$(get_version "mdbook")
 if [ -n "$MDBOOK_VERSION" ]; then
     echo "Installing mdBook ${MDBOOK_VERSION}..."
-    if ! output=$(cargo install mdbook --version "${MDBOOK_VERSION}" 2>&1); then
-        # Check for "already installed" error - cargo uses different messages
-        if echo "$output" | grep -qiE "(already exists in destination|is already installed)"; then
-            echo "  (already installed)"
-        else
-            echo "$output" >&2
-            exit 1
-        fi
-    fi
+    cargo install mdbook --version "${MDBOOK_VERSION}"
 else
     echo "Error: Could not find mdbook version in versions.toml"
     exit 1
@@ -59,15 +48,7 @@ while IFS= read -r line; do
         plugin="${BASH_REMATCH[1]}"
         version="${BASH_REMATCH[2]}"
         echo "Installing ${plugin} ${version}..."
-        if ! output=$(cargo install "${plugin}" --version "${version}" 2>&1); then
-            # Check for "already installed" error - cargo uses different messages
-            if echo "$output" | grep -qiE "(already exists in destination|is already installed)"; then
-                echo "  (already installed)"
-            else
-                echo "$output" >&2
-                exit 1
-            fi
-        fi
+        cargo install "${plugin}" --version "${version}"
     fi
 done < <(
     awk '