Skip to content

Support disabling placeholder creation #10

@stevelacey

Description

@stevelacey

I see what you're doing here but the step fails for my views and I can't be bothered to figure out why, it's a nice idea, but not necessary unless you're writing codependent views.

For the time being I have extended the package command for my own with this customization:

    public function makePlaceholderView(string $name, string $query)
    {
        // Placeholder query generation borks for non-simple views so lets not
        return $query;
    }

I suggest adding a config for this to bypass the functionality, and some explanation to the README for what's happening here, and make it either opt-in or opt-out, maybe it should be opt-in, since this tripped me up and I nearly abandoned installing the package until I read the source and worked out what was going on.

Nice idea, and great work, just not sure it should be on by default 👏

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions