Skip to content

Dynamic max bookmark setting needed? #528

@splitbrain

Description

@splitbrain

We currently cache the result of the renderer in addition to the generated PDF (see also #526). I like that because it makes the render results reusable over different (multi-page) exports.

However currently the number of bookmark levels (maxbookmarks) can be set dynamically via INPUT vars. See https://www.dokuwiki.org/plugin:dw2pdf:configuration#bookmarks

This means a the cache might use a setting that was provided via INPUT. When the next request wants a different level and a cache is found, the different level will not be applied.

So this feature is slightly broken. I assume it is super rare that anyone ever tweaks this setting at all. And it's probably rarer that it is done dynamically instead of using the config.

I propose to drop support for making this changable dynamically. I will do so in my refactoring, but this ticket is an opportunity to give feedback or argue back ;-)

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions