Allow enabling experimental wasm features (#3377)

Signed-off-by: Brian Hardock <[email protected]>

Author: fibonacci1729

.github/workflows/release.yml

@@ -120,7 +120,13 @@ jobs:
         with:
           openssl-windows: "${{ matrix.os == 'windows-latest' }}"
 
+      - name: build release (canary)
+        if: github.ref == 'refs/heads/main'
+        shell: bash
+        run: cargo build --features experimental-wasm-features --release ${{ matrix.config.extraArgs }}
+
       - name: build release
+        if: github.ref != 'refs/heads/main'
         shell: bash
         run: cargo build --release ${{ matrix.config.extraArgs }}
 

Cargo.toml

@@ -115,6 +115,7 @@ llm-metal = ["llm", "spin-runtime-factors/llm-metal"]
 llm-cublas = ["llm", "spin-runtime-factors/llm-cublas"]
 # This enables the collection and emission CPU time elapsed per component execution.
 cpu-time-metrics = ["spin-factors-executor/cpu-time-metrics"]
+experimental-wasm-features = ["spin-trigger/experimental-wasm-features"]
 
 [workspace]
 members = [

crates/trigger/Cargo.toml

@@ -13,6 +13,8 @@ rust-version.workspace = true
 # `ComponentLoader::enable_loading_aot_compiled_components`
 # documentation for more information about the safety risks.
 unsafe-aot-compilation = []
+# Enables configuring unstable Wasm features.
+experimental-wasm-features = []
 
 [dependencies]
 anyhow = { workspace = true }

crates/trigger/src/cli.rs

@@ -10,6 +10,8 @@ use std::path::PathBuf;
 use std::{future::Future, sync::Arc};
 
 use anyhow::{Context, Result};
+#[cfg(feature = "experimental-wasm-features")]
+use clap::ValueEnum;
 use clap::{Args, IntoApp, Parser};
 use spin_app::App;
 use spin_common::sloth;
@@ -111,6 +113,10 @@ pub struct FactorsTriggerCommand<T: Trigger<B::Factors>, B: RuntimeFactorsBuilde
     )]
     pub runtime_config_file: Option<PathBuf>,
 
+    #[cfg(feature = "experimental-wasm-features")]
+    #[clap(long, value_enum)]
+    pub experimental_wasm_feature: Vec<ExperimentalWasmFeature>,
+
     /// Set the application state directory path. This is used in the default
     /// locations for logs, key value stores, etc.
     ///
@@ -133,6 +139,15 @@ pub struct FactorsTriggerCommand<T: Trigger<B::Factors>, B: RuntimeFactorsBuilde
     pub launch_metadata_only: bool,
 }
 
+#[cfg(feature = "experimental-wasm-features")]
+#[derive(Clone, Debug, ValueEnum)]
+pub enum ExperimentalWasmFeature {
+    Gc,
+    ReferenceTypes,
+    Exceptions,
+    FunctionReferences,
+}
+
 /// Configuration options that are common to all triggers.
 #[derive(Debug, Default)]
 pub struct FactorsConfig {
@@ -212,6 +227,23 @@ impl<T: Trigger<B::Factors>, B: RuntimeFactorsBuilder> FactorsTriggerCommand<T,
             config.disable_pooling();
         }
 
+        #[cfg(feature = "experimental-wasm-features")]
+        {
+            let wasmtime_config = config.wasmtime_config();
+            for wasm_feature in self.experimental_wasm_feature {
+                match wasm_feature {
+                    ExperimentalWasmFeature::Gc => wasmtime_config.wasm_gc(true),
+                    ExperimentalWasmFeature::ReferenceTypes => {
+                        wasmtime_config.wasm_reference_types(true)
+                    }
+                    ExperimentalWasmFeature::Exceptions => wasmtime_config.wasm_exceptions(true),
+                    ExperimentalWasmFeature::FunctionReferences => {
+                        wasmtime_config.wasm_function_references(true)
+                    }
+                };
+            }
+        }
+
         let state_dir = match &self.state_dir {
             // Make sure `--state-dir=""` unsets the state dir
             Some(s) if s.is_empty() => UserProvidedPath::Unset,