Refactor item service and inventory management: update namespace for IItemService, fix item amount update logic, and clean up DbService properties

Author: sphexator

Hanekawa.Application/Interfaces/IItemService.cs

@@ -1,9 +1,6 @@
-using System;
-using System.Collections.Generic;
-using System.Threading.Tasks;
 using Hanekawa.Entities.Users;
 
-namespace Hanekawa.Application.Services;
+namespace Hanekawa.Application.Interfaces;
 
 public interface IItemService
 {
@@ -13,4 +10,4 @@ public interface IItemService
     ValueTask<IEnumerable<ItemType>> GetAllItemTypesAsync();
     ValueTask UseItemAsync(ulong guildId, ulong userId, Guid itemId);
     ValueTask<Item> CreateItemAsync(string name, string description, Guid typeId, int? price = null);
-}
+}

Hanekawa.Application/Services/InventoryService.cs

@@ -61,7 +61,7 @@ public async ValueTask UpdateInventoryAsync(GuildUser user, Inventory inventory)
         var item = existingUser.User.Inventory.FirstOrDefault(e => e.ItemId == inventory.ItemId);
         if (item is not null)
         {
-            item.Amount =+ inventory.Amount;
+            item.Amount += inventory.Amount;
         }
         else
         {

Hanekawa.Infrastructure/DbService.cs

@@ -14,29 +14,19 @@
 
 namespace Hanekawa.Infrastructure;
 
-/// <inheritdoc cref="Hanekawa.Application.Interfaces.IDbContext" />
 internal class DbService : DbContext, IDbContext
 {
     public DbService(DbContextOptions<DbService> options) : base(options) { }
-    /// <inheritdoc />
+
     public DbSet<Warning> Warnings { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<Log> Logs { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<GuildModerationLog> ModerationLogs { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<GuildConfig> GuildConfigs { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<GuildUser> Users { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<LevelRequirement> LevelRequirements { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<Club> Clubs { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<ClubMember> ClubMembers { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<Item> Items { get; set; } = null!;
-    /// <inheritdoc />
     public DbSet<ItemType> ItemTypes { get; set; } = null!;
 
     protected override void OnModelCreating(ModelBuilder modelBuilder)
@@ -157,20 +147,15 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
         });
     }
 
-    /// <param name="cancellationToken"></param>
-    /// <inheritdoc />
     public async Task<int> SaveChangesAsync(CancellationToken cancellationToken = default)
         => await base.SaveChangesAsync(cancellationToken);
 
-    /// <inheritdoc />
     public async Task<bool> EnsureDatabaseCreated(CancellationToken cancellationToken = default)
         => await base.Database.EnsureCreatedAsync(cancellationToken);
 
-    /// <inheritdoc />
     public async Task MigrateDatabaseAsync(CancellationToken cancellationToken = default)
         => await base.Database.MigrateAsync(cancellationToken: cancellationToken);
 
-    /// <inheritdoc />
     public DbConnection GetConnection()
     {
         return this.Database.GetDbConnection();