Skip to content

Commit 2aef504

Browse files
Apply suggestions from code review
Co-authored-by: Rem <[email protected]>
1 parent 862d97c commit 2aef504

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/en/wizden-staff/maintainer.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
# Maintainer
22

3-
This section contains information on Maintainer and PR-Review Policies, **as it pertains to Wizards Den servers, hosted by Space Wizards.** These policies do not apply to other servers, and may be waived in exceptional circumstances.
3+
This section contains information on Maintainer and PR-Review Policies, **as it pertains to Wizards Den servers, hosted by Space Wizards.** These policies do not apply to other servers and may be waived in exceptional circumstances.
44

55
## Maintainer
66

7-
A maintainer is a member of staff who is given authority and trust in reviewing and merging PRs. All maintainers regardless of specialization are expected to follow Maintainer Policy.
7+
A maintainer is a member of staff who is given authority and trust to review and merge PRs. All maintainers, regardless of specialization, are expected to follow the Maintainer Policy.
88

99
### SS14 Maintainer
1010

11-
A SS14 Maintainer maintains the content side of Space Station 14. This includes the docs repo, and content repo.
11+
A SS14 Maintainer maintains the content side of Space Station 14. This includes the docs repo and the content repo.
1212

1313
### Documaintainer
1414

15-
A Documaintainer is a SS14 Maintainer who only has Maintainer powers for the Docs Repo. Within the docs repo they have the same power and authority as an SS14 Maintainer.
15+
A Documaintainer is an SS14 maintainer who only has maintainer powers for the Docs Repo. Within the docs repo, they have the same power and authority as an SS14 maintainer.
1616

1717
### Head Mapper
1818

19-
A Head Mapper is a SS14 Maintainer who has exclusive power over content PRs with map changes and additions. These maintainers are expected to ensure mapping standards and their approval is required for any PRs which make mapping changes.
19+
A Head Mapper is an SS14 Maintainer who has exclusive power over content PRs with map changes and additions. These maintainers are expected to ensure mapping standards are met, and their approval is required for any PRs that make mapping changes.
2020

2121
### Art Lead
2222

23-
An Art Lead is a SS14 Maintainer who has exclusive power over content PRs with sprite changes and additions. These maintainers are expected to ensure the game maintains its art style and their approval is required for any PRs which make significant changes to existing sprites, or add new sprites.
23+
An Art Lead is an SS14 Maintainer who has exclusive power over content PRs with sprite changes and additions. These maintainers are expected to ensure the game maintains its art style, and their approval is required for any PRs that make significant changes to existing sprites or add new sprites.
2424

2525
### UI Lead
2626

27-
A UI Lead is a SS14 Maintainer who has exclusive power over content PRs with UI changes and additions. These maintainers are expected to ensure the game retains usable, aesthetically pleasing UIs which fit the game's art style.
27+
A UI Lead is an SS14 Maintainer who has exclusive power over content PRs with UI changes and additions. These maintainers are expected to ensure the game retains usable, aesthetically pleasing UIs which fit the game's art style.
2828

29-
### Robust Toolbox maintainer
29+
### Robust Toolbox Maintainer
3030

31-
A Robust Toolbox Maintainer is a Maintainer for the game's engine Robust Toolbox. These are the only Maintainers who have merge powers for the engine.
31+
A Robust Toolbox maintainer is a maintainer for the game's engine, Robust Toolbox. These are the only Maintainers who have merge powers for the engine.

src/en/wizden-staff/maintainer/hotfix-procedure.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Not following this procedure/policy will result in disciplinary action being tak
44
## Requirements
55
- **Three Maintainers must *sign-off*** (Approval is required, reviewing is recommended but optional) on a hotfix PR for it to be merged.
66
- The Hotfix procedure only applies to PRs being merged straight to "stable" or "staging". **When merging bugfixes to master, this procedure does NOT apply, use the normal PR procedure instead!**
7-
- All Hotfixes must adhere to the normal [PR Review Procedure](../maintainer/content-review-procedure.md) in addition to any requirements listed here.
7+
- All Hotfixes must adhere to the normal [PR review procedure](../maintainer/content-review-procedure.md) in addition to any requirements listed here.
88
- Hotfixes must be given the "Hotfix" label during triage. They will also automatically receive a label indicating their branch.
99
- Stable Hotfixes are for fixing bugs only, not for adding new content or minor balance adjustments. *If a balance issue is bad enough to majorly impact game quality, it should be considered a bug and is eligible for a hotfix. This is up to Maintainer judgment, but if you are unsure, it's recommended to create a discussion thread prefixed with "HOTFIX-PRNumber".
1010
- Hotfixes to Staging may include any changes that are deemed necessary for the upcoming release, but are otherwise still referred to as Hotfixes and follow these procedures.

0 commit comments

Comments
 (0)