fix bug when merging two ranges (#23)

* fix bug when merging two ranges

* add test to ci and update actions

Author: severo

.github/workflows/quality.yml .github/workflows/ci.yml.github/workflows/quality.yml renamed to .github/workflows/ci.yml

@@ -8,20 +8,27 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - run: npm i
       - run: npm run lint
 
   typecheck:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - run: npm i
       - run: npm run typecheck
 
   buildcheck:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - run: npm i
       - run: npm run build
+
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - run: npm i
+      - run: npm run test

.github/workflows/deploy_pages.yml

@@ -11,14 +11,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout the repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Build
         run: |
           npm i
           npm run build
       - name: Upload static files as artifact
         id: deployment
-        uses: actions/upload-pages-artifact@v3
+        uses: actions/upload-pages-artifact@v4
         with:
           path: dist/
 

src/cache.ts

@@ -158,6 +158,7 @@ export class CSVRange {
       throw new Error('Cannot merge ranges: not contiguous')
     }
     this.#byteCount += followingRange.byteCount
+    this.#rowByteCount += followingRange.rowByteCount
     for (const row of followingRange.rows) {
       this.#rows.push(row)
     }

test/cache.test.ts

@@ -99,6 +99,7 @@ describe('CSVRange', () => {
       byteOffset: 10,
       byteCount: 10,
     })
+    expect(range1.rowByteCount).toBe(10)
 
     const range2 = new CSVRange({ firstByte: 20, firstRow: 2 })
     range2.append({
@@ -110,12 +111,14 @@ describe('CSVRange', () => {
       byteOffset: 30,
       byteCount: 10,
     })
+    expect(range2.rowByteCount).toBe(10)
 
     range1.merge(range2)
 
     expect(range1.rowCount).toBe(2)
     expect(range1.byteCount).toBe(40)
     expect(range1.firstRow).toBe(0)
+    expect(range1.rowByteCount).toBe(20)
     expect(range1.next).toStrictEqual({ firstByte: 40, row: 2 })
     expect(range1.rows).toEqual([['b', 'c', 'd'], ['e', 'f', 'g']])
     expect(range1.getCells({ row: 0 })).toEqual(['b', 'c', 'd'])