Skip to content

Commit 5954e77

Browse files
Merge branch 'main' into feat/migrating-to-v2-guide
2 parents 088f8e5 + 7b23a26 commit 5954e77

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

src/ui/callout.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { Alert } from "@kobalte/core";
21
import { Icon } from "solid-heroicons";
32
import { mergeProps, type JSX, Show, untrack } from "solid-js";
43
import {
@@ -91,7 +90,7 @@ export function Callout(props: CalloutProps) {
9190
const IconComponent = icons[iconType];
9291

9392
return (
94-
<Alert.Root
93+
<div
9594
class={`my-6 flex w-full rounded-3xl border p-4 ${
9695
styles[mergedProps.type].container
9796
}`}
@@ -112,6 +111,6 @@ export function Callout(props: CalloutProps) {
112111
{mergedProps.children}
113112
</div>
114113
</div>
115-
</Alert.Root>
114+
</div>
116115
);
117116
}

src/ui/eraser-link/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,15 @@ const EraserLink = (
6767
class="relative inline-block"
6868
target="_blank"
6969
rel="noopener noreferrer"
70+
aria-label="View diagram on Eraser.io"
7071
>
7172
<img
7273
src={
7374
elementParams
7475
? `${workspaceUrl}/preview?${elementParams}&type=embed`
7576
: `${workspaceUrl}/preview`
7677
}
77-
alt={""}
78+
alt=""
7879
onLoad={() => setIsLoaded(true)}
7980
/>
8081
{isLoaded() ? (

src/ui/layout.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,10 @@ export const Layout: ParentComponent<{ isError?: boolean }> = (props) => {
157157
</Suspense>
158158
</div>
159159
</Show>
160-
<main class="prose prose-slate w-full flex-auto px-4 pt-2 dark:prose-invert md:max-w-2xl md:pb-16 lg:max-w-none dark:text-slate-300">
160+
<main
161+
class="prose prose-slate w-full flex-auto px-4 pt-2 dark:prose-invert md:max-w-2xl md:pb-16 lg:max-w-none dark:text-slate-300"
162+
aria-live="polite"
163+
>
161164
<Show
162165
when={!useCurrentRouteMetaData().isProjectRoot}
163166
keyed

src/ui/layout/mobile-navigation.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ export const [isOpen, setIsOpen] = createSignal(false);
2424
export const MobileNavigation = (props: NavProps) => {
2525
return (
2626
<Dialog.Root open={isOpen()} onOpenChange={setIsOpen}>
27-
<Dialog.Trigger>
27+
<Dialog.Trigger
28+
aria-label="Open navigation menu"
29+
title="Open navigation menu"
30+
>
2831
<Icon path={bars_3} class="prose h-6 dark:prose-invert" />
2932
</Dialog.Trigger>
3033
<Dialog.Portal>

0 commit comments

Comments
 (0)