address PR comments

Author: atk

packages/storage/README.md

@@ -51,7 +51,7 @@ type PersistedOptions<Type, StorageOptions> = {
 - values persisted in asynchronous storage APIs will not overwrite already changed signals or stores
 - setting a persisted signal to undefined or null will remove the item from the storage
 - to use `makePersisted` with other state management APIs, you need some adapter that will project your API to either the output of `createSignal` or `createStore`
-- if you experience hydration mismatch issues, add `isHydrated` from the [lifecycles package](../lifecycle/) to your options to delay the initialization until the parent component is hydrated
+- if you experience hydration mismatch issues, set `deferInit` to true to delay the initialization from storage until the parent component is hydrated - this way, client and server will use the same initial data and avoid hydration conflicts
 
 ### Using `makePersisted` with resources
 
@@ -68,7 +68,7 @@ result is discarded not to overwrite more current data.
 
 ### Using `makePersisted` with Suspense
 
-In case you are using an asynchronous storage and want the initialisation mesh into Suspense instead of mixing it with Show, we provide the output of the initialisation as third part of the returned tuple:
+In case you are using an asynchronous storage and want the initialization mesh into Suspense instead of mixing it with Show, we provide the output of the initialization as third part of the returned tuple:
 
 ```ts
 const [state, setState, init] = makePersisted(createStore({}), {

packages/storage/src/persisted.ts

@@ -1,5 +1,5 @@
 import type { Accessor, Setter, Signal } from "solid-js";
-import { createEffect, createRoot, createUniqueId, untrack } from "solid-js";
+import { onMount, createUniqueId, untrack } from "solid-js";
 import { isServer, isDev } from "solid-js/web";
 import type { SetStoreFunction, Store } from "solid-js/store";
 import { reconcile } from "solid-js/store";
@@ -67,8 +67,8 @@ export type PersistenceOptions<T, O extends Record<string, any> | undefined> = {
   deserialize?: (data: string) => T;
   /** Add one of the existing Sync APIs to sync storages over boundaries or provide your own */
   sync?: PersistenceSyncAPI;
-  /** If you experience hydration mismatch issues, add `isHydrated` from `@solid-primitives/lifecycle` here */
-  isHydrated?: () => boolean;
+  /** If you experience hydration mismatch issues, set this to true to defer initial loading from store until after onMount */
+  deferInit?: boolean;
 } & (undefined extends O
   ? { storage?: SyncStorage | AsyncStorage }
   : {
@@ -161,8 +161,8 @@ export function makePersisted<
     if (init instanceof Promise) init.then(data => unchanged && data && set(data));
     else if (init) set(init);
   };
-  if (typeof options.isHydrated === "function") {
-    createRoot(dispose => createEffect(() => options.isHydrated?.() && (initialize(), dispose())));
+  if (options.deferInit) {
+    onMount(initialize);
   } else {
     initialize();
   }