Commit 59c3de7
authored
[iOS] Fix
## Description
Our check for `ScrollView` was checking for
`RCTScrollViewComponentView`, but inside NativeDetector, we extract
`contentView` from `RCTViewComponentViews`:
https://github.com/software-mansion/react-native-gesture-handler/blob/08c46d8232ce41dc195459b8b58b5d818bdfd15f/packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm#L298-L303
And it so happens that `RCTScrollViewComponentView` inherits from
`RCTViewComponentView`, which broke the `ScrollView` detection. The
`contentView` of `RCTScrollViewComponentView` is
`RCTEnhancedScrollView`.
## Test plan
ScrollView from RNGH should now correctly delay touches on native
buttons.ScrollView detection when used with NativeDetector (#3888)1 parent 6352af3 commit 59c3de7
File tree
1 file changed
+5
-0
lines changed- packages/react-native-gesture-handler/apple
1 file changed
+5
-0
lines changedLines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
646 | 647 | | |
647 | 648 | | |
648 | 649 | | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
649 | 654 | | |
650 | 655 | | |
651 | 656 | | |
| |||
0 commit comments