[Tests] Add tests of invalid redirect hostname or failed connection

Author: smithdh

tests/cluster/setup.sh

@@ -13,8 +13,8 @@ set -e
 : ${CRC32C:=$(command -v xrdcrc32c)}
 : ${STAT:=$(command -v stat)}
 
-servernames=("metaman" "man1" "man2" "srv1" "srv2" "srv3" "srv4")
-datanodes=("srv1" "srv2" "srv3" "srv4")
+servernames=("metaman" "man1" "man2" "srv1" "srv2" "srv3" "srv4" "srv-bad-redir1" "srv-bad-redir2")
+datanodes=("srv1" "srv2" "srv3" "srv4" "srv-bad-redir1" "srv-bad-redir2")
 
 DATAFOLDER="./data"
 TMPDATAFOLDER="./rout"
@@ -147,6 +147,10 @@ start(){
        generate
        set -x
        # start for each component
+
+       # temporary hostname to start one of the bad redirect servers
+       echo "127.0.0.1 localhostx" >> /etc/hosts
+
        for i in "${servernames[@]}"; do
               ${XROOTD} -b -k fifo -n ${i} -l xrootd.log -s xrootd.pid -c ${i}.cfg
        done
@@ -157,6 +161,9 @@ start(){
        done
 
        sleep 1
+
+       # remove remporary hostname
+       sed -i '$ d' /etc/hosts
 }
 
 stop() {

tests/cluster/srv-bad-redir1.cfg

@@ -0,0 +1,12 @@
+set name = srv4
+
+all.role server
+
+xrd.port 10951
+xrootd.redirect localhost:10950 chmod
+
+if exec xrootd
+xrd.protocol XrdHttp:10951 libXrdHttp.so
+fi
+
+continue @CMAKE_CURRENT_BINARY_DIR@/common.cfg

tests/cluster/srv-bad-redir2.cfg

@@ -0,0 +1,12 @@
+set name = srv4
+
+all.role server
+
+xrd.port 10952
+xrootd.redirect localhostx:10950 chmod
+
+if exec xrootd
+xrd.protocol XrdHttp:10952 libXrdHttp.so
+fi
+
+continue @CMAKE_CURRENT_BINARY_DIR@/common.cfg

tests/cluster/test.sh

@@ -20,6 +20,8 @@ fi
 : ${HOST_SRV2:=root://localhost:10944}
 : ${HOST_SRV3:=root://localhost:10945}
 : ${HOST_SRV4:=root://localhost:10946}
+: ${HOST_BAD_REDIR1:=root://localhost:10951}
+: ${HOST_BAD_REDIR2:=root://localhost:10952}
 
 : ${HOST_HTTP_METAMAN:=${HOST_METAMAN/root/http}}
 : ${HOST_HTTP_MAN1:=${HOST_MAN1/root/http}}
@@ -207,5 +209,23 @@ wait
 
 ${XRDFS} ${HOST_METAMAN} rmdir ${RMTDATADIR}
 
+XRD_CONNECTIONRETRY=0 ${XRDFS} ${HOST_BAD_REDIR1} chmod /dkjdkjd rwx------ 2> /tmp/err.txt
+ret1=$?
+grep -q "\[FATAL\] Connection error" /tmp/err.txt
+ret2=$?
+if [ $ret1 -ne 51 -o $ret2 -ne 0 ]; then
+  echo "${host}: bad redirect test 1 did not fail as expected"
+  exit 1
+fi
+
+XRD_CONNECTIONRETRY=0 ${XRDFS} ${HOST_BAD_REDIR2} chmod /dkjdkjd rwx------ 2> /tmp/err.txt
+ret1=$?
+grep -q "\[FATAL\] Invalid address" /tmp/err.txt
+ret2=$?
+if [ $ret1 -ne 51 -o $ret2 -ne 0 ]; then
+  echo "${host}: bad redirect test 2 did not fail as expected"
+  exit 1
+fi
+
 echo "ALL TESTS PASSED"
 exit 0