Skip to content

Commit 55a45a6

Browse files
authored
lsp/ui: Remove redundant callback handlers from HeaderView (#9756)
Remove unused callback definitions and handlers that became redundant after switching to direct property bindings for widget state management.
1 parent 8513cfe commit 55a45a6

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

tools/lsp/ui/main.slint

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -210,18 +210,6 @@ export component PreviewUi inherits Window {
210210
style-selected => {
211211
Api.style-changed();
212212
}
213-
library-toggled(val) => {
214-
root.library-widget = val;
215-
}
216-
outline-toggled(val) => {
217-
root.outline-widget = val;
218-
}
219-
properties-toggled(val) => {
220-
root.properties-widget = val;
221-
}
222-
simulator-toggled(val) => {
223-
root.data-widget = val;
224-
}
225213
edit := Button {
226214
icon: Icons.inspect;
227215
colorize-icon: preview.select-mode ? false : true;

tools/lsp/ui/views/header-view.slint

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@ export component HeaderView {
1818
in-out property <bool> data-widget <=> shortcut-simulator-data.checked;
1919

2020
callback style-selected();
21-
callback edit-mode-toggled();
22-
callback library-toggled(bool);
23-
callback properties-toggled(bool);
24-
callback outline-toggled(bool);
25-
callback simulator-toggled(bool);
2621

2722
background-layer := Rectangle {
2823
background: Palette.alternate-background;
@@ -68,9 +63,6 @@ export component HeaderView {
6863

6964
interaction-switch := Switch {
7065
checked: true;
71-
toggled => {
72-
root.edit-mode-toggled();
73-
}
7466
}
7567

7668
BodyText {
@@ -87,10 +79,6 @@ export component HeaderView {
8779
icon: Icons.library;
8880
colorize-icon: !self.checked;
8981
primary: self.checked;
90-
clicked => {
91-
root.library-toggled(self.checked);
92-
library-widget = self.checked;
93-
}
9482
}
9583

9684
shortcut-properties := Button {
@@ -99,10 +87,6 @@ export component HeaderView {
9987
icon: Icons.properties;
10088
colorize-icon: !self.checked;
10189
primary: self.checked;
102-
clicked => {
103-
root.properties-toggled(self.checked);
104-
properties-widget = self.checked;
105-
}
10690
}
10791

10892
shortcut-outline := Button {
@@ -111,10 +95,6 @@ export component HeaderView {
11195
icon: Icons.outline;
11296
colorize-icon: !self.checked;
11397
primary: self.checked;
114-
clicked => {
115-
root.outline-toggled(self.checked);
116-
outline-widget = self.checked;
117-
}
11898
}
11999

120100
shortcut-simulator-data := Button {
@@ -123,10 +103,6 @@ export component HeaderView {
123103
icon: Icons.simulator;
124104
colorize-icon: !self.checked;
125105
primary: self.checked;
126-
clicked => {
127-
root.simulator-toggled(self.checked);
128-
data-widget = self.checked;
129-
}
130106
}
131107
}
132108
}

0 commit comments

Comments
 (0)