Skip to content

Duplicate code in conv3d #220

@MaxFBurg

Description

@MaxFBurg

in conv3d there is some code that is duplicate with conv2d, e.g. https://github.com/ecker-lab/neuralpredictors/blob/29206ece4ed20af57f7c6e5ee614e49da50dd8d5/neuralpredictors/layers/cores/conv3d.py#L228 . Ideally, these functions would not be duplicate, as for example with PR #217 batch norm handling evolved in conv2d, and conv3d is missing the new features but could have had it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions