Skip to content

Commit 340615f

Browse files
committed
Release 4.0.2
1 parent 1ea8ed7 commit 340615f

File tree

4 files changed

+22
-20
lines changed

4 files changed

+22
-20
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-facebook",
3-
"version": "4.0.1",
3+
"version": "4.0.2",
44
"description": "Facebook components like a Login button, Like, Share, Comments or Embedded Post",
55
"author": {
66
"name": "Zlatko Fedor",

src/Login.jsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ export default class Login extends Process {
66
...Process.propTypes,
77
scope: PropTypes.string.isRequired,
88
fields: PropTypes.array.isRequired,
9-
onError: PropTypes.func.isRequired,
10-
onResponse: PropTypes.func.isRequired,
11-
onReady: PropTypes.func,
129
returnScopes: PropTypes.bool,
1310
rerequest: PropTypes.bool,
1411
};
@@ -20,7 +17,6 @@ export default class Login extends Process {
2017
'name', 'email', 'locale', 'gender', 'timezone', 'verified', 'link'],
2118
returnScopes: false,
2219
rerequest: false,
23-
onReady: undefined,
2420
};
2521

2622
async process(facebook) {

src/LoginButton.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React, { Component } from 'react';
22
import PropTypes from 'prop-types';
33
import Spinner from 'react-spinner-children';
4-
import FacebookLogin from './Login';
4+
import Login from './Login';
55

66
export default class LoginButton extends Component {
77
static propTypes = {
8-
...FacebookLogin.propTypes,
8+
...Login.propTypes,
99
spinnerConfig: PropTypes.object.isRequired,
1010
children: PropTypes.node,
1111
className: PropTypes.string,
@@ -17,7 +17,7 @@ export default class LoginButton extends Component {
1717
};
1818

1919
static defaultProps = {
20-
...FacebookLogin.defaultProps,
20+
...Login.defaultProps,
2121
spinnerConfig: {},
2222
buttonClassName: 'btn btn-lg',
2323
iconClassName: 'fa fa-facebook pull-left',
@@ -37,7 +37,7 @@ export default class LoginButton extends Component {
3737
} = this.props;
3838

3939
return (
40-
<FacebookLogin
40+
<Login
4141
{...rest}
4242
render={({ isWorking, isLoading, onClick }) => (
4343
<button

src/Process.jsx

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,17 @@ export default class Process extends Component {
77
children: PropTypes.node,
88
render: PropTypes.func,
99
component: PropTypes.node,
10+
onReady: PropTypes.func,
11+
onError: PropTypes.func,
1012
onResponse: PropTypes.func,
1113
};
1214

1315
static defaultProps = {
1416
children: undefined,
1517
render: undefined,
1618
component: undefined,
19+
onReady: undefined,
20+
onError: undefined,
1721
onResponse: undefined,
1822
};
1923

@@ -41,23 +45,25 @@ export default class Process extends Component {
4145
if (onResponse) {
4246
await onResponse(response);
4347
}
44-
45-
this.setState({
46-
isWorking: false,
47-
});
48-
49-
return response;
5048
} catch (e) {
51-
this.setState({
52-
isWorking: false,
53-
});
54-
55-
throw e;
49+
const { onError } = this.props;
50+
if (onError) {
51+
await onError(e);
52+
}
5653
}
54+
55+
this.setState({
56+
isWorking: false,
57+
});
5758
}
5859

5960
handleFacebookReady = (facebook) => {
6061
this.setState({ facebook });
62+
63+
const { onReady } = this.props;
64+
if (onReady) {
65+
onReady(facebook);
66+
}
6167
}
6268

6369
getElement() {

0 commit comments

Comments
 (0)