Python version check in test/run-pytest is too strict

[befeleme]

The check in run-pytest is too strict:

s2i-python-container/test/run-pytest

Lines 11 to 15 in 39f57df

	PYTHON_VERSION="3.12"
	if [[ ! -f "/usr/bin/python$PYTHON_VERSION" ]]; then
	PYTHON_VERSION="3.13"
	fi
	cd "${THISDIR}" && "python${PYTHON_VERSION}" -m pytest -s -rA --showlocals -vv test_container_*.py

The tests run on Fedora Latest image. This is now F43 with the default interpreter Python 3.14. But that one is not in the testing script, making it impossible to run tests.

Is there a reason a system interpreter can't be used any time?

Instead of hardcoded heuristics, the invocation of the tests could just be python3 -m pytest -s -rA --showlocals -vv test_container_*.py.

cc @phracek

[phracek]

Is there a reason a system interpreter can't be used any time?

Instead of hardcoded heuristics, the invocation of the tests could just be python3 -m pytest -s -rA --showlocals -vv test_container_*.py.

System interpreter can be used. No problem.
The run-pytest is executed on RHEL8, RHEL9 and I hope it uses Python 3.12 or higher. And not Python 3.9 or lower. That was the reason.

[befeleme]

How about something like this? (untested)

# - If version is <= 3.12, use 3.12
# - If version is > 3.12, use that higher version
PYTHON_VERSION="3.12"

for version in 3.14 3.13; do
  if [[ -f "/usr/bin/python$version" ]]; then
    PYTHON_VERSION="$version"
    break
  fi
done

[phracek]

For general usage:

if python3 -c 'import sys; sys.exit(0 if sys.version_info < (3,13) else 1)'; then
  PYTHON_VERSION="3.12"
else
  PYTHON_VERSION="3"
fi

[befeleme]

In what file is it defined what version of Python will be installed in the container? How is Python 3.12 installed in C9S container? Can we maybe control the Python versions installed there, and invoke the "highest" possible? (So that the invocation step is always the same)

[phracek]

Fixed by #783