Skip to content

Commit c35f96a

Browse files
cboulayzeyus
authored andcommitted
Try signing and packaging before uploading artifact
1 parent b53e91f commit c35f96a

File tree

1 file changed

+26
-1
lines changed

1 file changed

+26
-1
lines changed

.github/workflows/apple.yml

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,31 @@ jobs:
112112
--notarize \
113113
--output package
114114
115+
- name: Package and Notarize macOS Installer
116+
if: matrix.config.name == 'macOS-latest'
117+
env:
118+
APPLE_DEVELOPMENT_TEAM: ${{ secrets.PROD_MACOS_NOTARIZATION_TEAM_ID }}
119+
APPLE_NOTARIZE_USERNAME: ${{ secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }}
120+
APPLE_NOTARIZE_PASSWORD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
121+
run: |
122+
# Get the version number from the framework's Info.plist
123+
LSL_VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" install/Frameworks/lsl.framework/Versions/A/Resources/Info.plist)
124+
echo "LSL_VERSION=$LSL_VERSION" >> $GITHUB_ENV
125+
echo "Debug: LSL_VERSION=$LSL_VERSION"
126+
127+
mkdir -p package
128+
productbuild --sign "$APPLE_CODE_SIGN_IDENTITY_INST" \
129+
--component install/Frameworks/lsl.framework \
130+
/Library/Frameworks package/liblsl-${LSL_VERSION}-Darwin-universal.pkg
131+
# Notarize the package
132+
xcrun notarytool submit package/liblsl-${LSL_VERSION}-Darwin-universal.pkg \
133+
--apple-id "$APPLE_NOTARIZE_USERNAME" \
134+
--password "$APPLE_NOTARIZE_PASSWORD" \
135+
--team-id "$APPLE_DEVELOPMENT_TEAM" \
136+
--wait
137+
# Staple the notarization ticket to the package
138+
xcrun stapler staple package/liblsl-${LSL_VERSION}-Darwin-universal.pkg
139+
115140
- name: upload dump
116141
if: failure()
117142
uses: actions/upload-artifact@v4
@@ -175,7 +200,7 @@ jobs:
175200
176201
- name: Unzip macOS Framework
177202
run: |
178-
unzip build-macOS-latest/lsl.framework.zip -d build-macOS-latest/Frameworks
203+
unzip build-macOS-latest/install/Frameworks/lsl.framework.zip -d build-macOS-latest/Frameworks
179204
180205
- name: Unzip iOS Framework
181206
run: |

0 commit comments

Comments
 (0)