Always set ASIO_DISABLE_VISIBILITY to keep asio symbols hidden in liblsl.

Author: cboulay

CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required (VERSION 3.23)
 project (liblsl
-	VERSION 1.17.4
+	VERSION 1.17.5
 	LANGUAGES C CXX
 	DESCRIPTION "Labstreaminglayer C/C++ library"
 	HOMEPAGE_URL "https://github.com/sccn/liblsl"

cmake/TargetObjLib.cmake

@@ -39,6 +39,11 @@ target_compile_definitions(lslobj
     PRIVATE
         LIBLSL_EXPORTS
         LOGURU_DEBUG_LOGGING=$<BOOL:${LSL_DEBUGLOG}>
+        # Prevent asio from overriding CMAKE_CXX_VISIBILITY_PRESET with its own
+        # #pragma GCC visibility push(default). This ensures asio symbols stay
+        # hidden in the final shared library, avoiding ODR violations when
+        # applications also use standalone asio.
+        ASIO_DISABLE_VISIBILITY
     PUBLIC
         ASIO_NO_DEPRECATED
         $<$<CXX_COMPILER_ID:MSVC>:LSLNOAUTOLINK>  # don't use #pragma(lib) in CMake builds
@@ -71,11 +76,7 @@ if(NOT LSL_OPTIMIZATIONS)
     # build one object file for Asio instead of once every time an Asio function is called. See
     # https://think-async.com/Asio/asio-1.18.2/doc/asio/using.html#asio.using.optional_separate_compilation
     target_sources(lslobj PRIVATE thirdparty/asio_objects.cpp)
-    target_compile_definitions(lslobj
-        PUBLIC
-            ASIO_SEPARATE_COMPILATION
-            ASIO_DISABLE_VISIBILITY
-    )
+    target_compile_definitions(lslobj PUBLIC ASIO_SEPARATE_COMPILATION)
 endif()
 
 # - pugixml