Skip to content

Commit 6a5289c

Browse files
committed
Refactor JdbcAdmin
1 parent 7a43860 commit 6a5289c

File tree

7 files changed

+905
-742
lines changed

7 files changed

+905
-742
lines changed

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminTestUtils.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,27 @@ public JdbcAdminTestUtils(Properties properties) {
3030
@Override
3131
public void dropNamespacesTable() throws Exception {
3232
execute(
33-
"DROP TABLE " + rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.NAMESPACES_TABLE));
33+
"DROP TABLE "
34+
+ rdbEngine.encloseFullTableName(
35+
metadataSchema, NamespaceMetadataService.NAMESPACES_TABLE));
3436
}
3537

3638
@Override
3739
public void dropMetadataTable() throws Exception {
38-
dropTable(metadataSchema, JdbcAdmin.METADATA_TABLE);
40+
dropTable(metadataSchema, TableMetadataService.METADATA_TABLE);
3941
}
4042

4143
@Override
4244
public void truncateNamespacesTable() throws Exception {
4345
String truncateTableStatement =
44-
rdbEngine.truncateTableSql(metadataSchema, JdbcAdmin.NAMESPACES_TABLE);
46+
rdbEngine.truncateTableSql(metadataSchema, NamespaceMetadataService.NAMESPACES_TABLE);
4547
execute(truncateTableStatement);
4648
}
4749

4850
@Override
4951
public void truncateMetadataTable() throws Exception {
5052
String truncateTableStatement =
51-
rdbEngine.truncateTableSql(metadataSchema, JdbcAdmin.METADATA_TABLE);
53+
rdbEngine.truncateTableSql(metadataSchema, TableMetadataService.METADATA_TABLE);
5254
execute(truncateTableStatement);
5355
}
5456

@@ -57,7 +59,7 @@ public void truncateMetadataTable() throws Exception {
5759
public void corruptMetadata(String namespace, String table) throws Exception {
5860
String insertCorruptedMetadataStatement =
5961
"INSERT INTO "
60-
+ rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.METADATA_TABLE)
62+
+ rdbEngine.encloseFullTableName(metadataSchema, TableMetadataService.METADATA_TABLE)
6163
+ " VALUES ('"
6264
+ getFullTableName(namespace, table)
6365
+ "','corrupted','corrupted','corrupted','corrupted','0','0')";
@@ -68,9 +70,9 @@ public void corruptMetadata(String namespace, String table) throws Exception {
6870
public void deleteMetadata(String namespace, String table) throws Exception {
6971
String deleteMetadataStatement =
7072
"DELETE FROM "
71-
+ rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.METADATA_TABLE)
73+
+ rdbEngine.encloseFullTableName(metadataSchema, TableMetadataService.METADATA_TABLE)
7274
+ " WHERE "
73-
+ rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
75+
+ rdbEngine.enclose(TableMetadataService.METADATA_COL_FULL_TABLE_NAME)
7476
+ " = ?";
7577
try (Connection connection = dataSource.getConnection();
7678
PreparedStatement preparedStatement =

core/src/integration-test/java/com/scalar/db/storage/multistorage/MultiStorageAdminTestUtils.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
import com.scalar.db.storage.cassandra.CassandraAdmin;
1010
import com.scalar.db.storage.cassandra.CassandraConfig;
1111
import com.scalar.db.storage.cassandra.ClusterManager;
12-
import com.scalar.db.storage.jdbc.JdbcAdmin;
1312
import com.scalar.db.storage.jdbc.JdbcConfig;
1413
import com.scalar.db.storage.jdbc.JdbcTestUtils;
1514
import com.scalar.db.storage.jdbc.JdbcUtils;
15+
import com.scalar.db.storage.jdbc.NamespaceMetadataService;
1616
import com.scalar.db.storage.jdbc.RdbEngineFactory;
1717
import com.scalar.db.storage.jdbc.RdbEngineStrategy;
18+
import com.scalar.db.storage.jdbc.TableMetadataService;
1819
import com.scalar.db.util.AdminTestUtils;
1920
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
2021
import java.sql.Connection;
@@ -61,7 +62,8 @@ public void dropNamespacesTable() throws SQLException {
6162
// for JDBC
6263
execute(
6364
"DROP TABLE "
64-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.NAMESPACES_TABLE));
65+
+ rdbEngine.encloseFullTableName(
66+
jdbcMetadataSchema, NamespaceMetadataService.NAMESPACES_TABLE));
6567
}
6668

6769
@Override
@@ -71,7 +73,8 @@ public void dropMetadataTable() throws SQLException {
7173
// for JDBC
7274
execute(
7375
"DROP TABLE "
74-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE));
76+
+ rdbEngine.encloseFullTableName(
77+
jdbcMetadataSchema, TableMetadataService.METADATA_TABLE));
7578
}
7679

7780
@Override
@@ -86,7 +89,7 @@ public void truncateNamespacesTable() throws SQLException {
8689

8790
// for JDBC
8891
String truncateTableStatement =
89-
rdbEngine.truncateTableSql(jdbcMetadataSchema, JdbcAdmin.NAMESPACES_TABLE);
92+
rdbEngine.truncateTableSql(jdbcMetadataSchema, NamespaceMetadataService.NAMESPACES_TABLE);
9093
execute(truncateTableStatement);
9194
}
9295

@@ -97,7 +100,8 @@ public void truncateMetadataTable() throws Exception {
97100
// for JDBC
98101
String truncateTableStatement =
99102
"TRUNCATE TABLE "
100-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE);
103+
+ rdbEngine.encloseFullTableName(
104+
jdbcMetadataSchema, TableMetadataService.METADATA_TABLE);
101105
execute(truncateTableStatement);
102106
}
103107

@@ -109,7 +113,8 @@ public void corruptMetadata(String namespace, String table) throws Exception {
109113
// for JDBC
110114
String insertCorruptedMetadataStatement =
111115
"INSERT INTO "
112-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE)
116+
+ rdbEngine.encloseFullTableName(
117+
jdbcMetadataSchema, TableMetadataService.METADATA_TABLE)
113118
+ " VALUES ('"
114119
+ getFullTableName(namespace, table)
115120
+ "','corrupted','corrupted','corrupted','corrupted','0','0')";
@@ -123,9 +128,10 @@ public void deleteMetadata(String namespace, String table) throws Exception {
123128
// for JDBC
124129
String deleteMetadataStatement =
125130
"DELETE FROM "
126-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE)
131+
+ rdbEngine.encloseFullTableName(
132+
jdbcMetadataSchema, TableMetadataService.METADATA_TABLE)
127133
+ " WHERE "
128-
+ rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
134+
+ rdbEngine.enclose(TableMetadataService.METADATA_COL_FULL_TABLE_NAME)
129135
+ " = ?";
130136
try (Connection connection = dataSource.getConnection();
131137
PreparedStatement preparedStatement =

0 commit comments

Comments
 (0)