more progress

Author: santisq

src/ADEffectiveAccess/DirectoryEntryBuilder.cs

@@ -12,9 +12,9 @@ internal sealed class DirectoryEntryBuilder : IDisposable
 
     private readonly AuthenticationTypes _authenticationTypes;
 
-    internal DirectoryEntry RootEntry { get => field ??= Create(); }
+    internal DirectoryEntry RootEntry { get; }
 
-    internal string? Root { get => field ??= RootEntry.Properties["distinguishedName"][0]?.ToString(); }
+    internal string? Root { get; }
 
     internal DirectoryEntryBuilder(
         PSCredential? credential,
@@ -23,6 +23,8 @@ internal DirectoryEntryBuilder(
         _username = credential?.UserName;
         _password = credential?.GetNetworkCredential().Password;
         _authenticationTypes = authenticationTypes;
+        RootEntry = Create();
+        Root = RootEntry.Properties["distinguishedName"][0]?.ToString();
     }
 
     internal DirectoryEntry Create(string? path = null) =>

src/ADEffectiveAccess/Extensions.cs

@@ -30,14 +30,14 @@ internal static void WriteInvalidSecurityDescriptorError(this SearchResult obj,
                 new InvalidOperationException($"No Security Descriptor found for '{obj.Path}'."),
                 "InvalidSecurityDescriptorType", ErrorCategory.InvalidResult, obj));
 
-    // internal static void WriteIdentityNotFoundError(this DirectoryEntry root, string identity, PSCmdlet cmdlet)
-    //     => cmdlet.WriteError(
-    //         new ErrorRecord(
-    //             new IdentityNotMappedException(
-    //                 $"Cannot find an object with identity: '{identity}' under: '{root.Properties["distinguishedName"][0]}'."),
-    //             "IvalidIdentity", ErrorCategory.InvalidResult, identity));
+    internal static void WriteIdentityNotFoundError(this IdentityNotMappedException exception, PSCmdlet cmdlet)
+        => cmdlet.WriteError(
+            new ErrorRecord(exception, "IvalidIdentity", ErrorCategory.InvalidResult, null));
+
+    internal static void WriteUnderterminedError(this Exception exception, PSCmdlet cmdlet)
+        => cmdlet.WriteError(
+            new ErrorRecord(exception, "UnderterminedError", ErrorCategory.NotSpecified, null));
 
     internal static IdentityNotMappedException ToIdentityNotFoundException(this string identity, string? rootDn)
-        => new IdentityNotMappedException(
-            $"Cannot find an object with identity: '{identity}' under: '{rootDn}'.");
+        => new($"Cannot find an object with identity: '{identity}' under: '{rootDn}'.");
 }

src/ADEffectiveAccess/GetADEffectiveAccessComand.cs

@@ -18,16 +18,15 @@ public sealed class GetADEffectiveAccessComand : PSCmdlet, IDisposable
 
     private DirectoryEntryBuilder? _entryBuilder;
 
-    // [ThreadStatic]
-    // private static GuidResolver? _map;
-
     private GuidResolver? _map;
 
     [Parameter(
         Position = 0,
         Mandatory = true,
+        ValueFromPipeline = true,
         ValueFromPipelineByPropertyName = true,
         ParameterSetName = IdentitySet)]
+    [Alias("DistinguishedName", "ObjectGuid", "ObjectSid", "SamAccountName")]
     public string Identity { get; set; } = null!;
 
     [Parameter(Position = 0, ParameterSetName = FilterSet)]
@@ -82,45 +81,60 @@ protected override void BeginProcessing()
     protected override void ProcessRecord()
     {
         if (_entryBuilder is null) return;
-        if (_map is null) return;
 
-        using DirectoryEntry root = GetRootEntry(_entryBuilder);
-        using DirectorySearcher searcher = new(root, LdapFilter, [SecurityDescriptor])
-        {
-            SizeLimit = Top,
-            Tombstone = IncludeDeletedObjects,
-            SearchScope = SearchScope,
-            PageSize = PageSize,
-            SecurityMasks = SecurityMasks.Group |
-                SecurityMasks.Dacl |
-                SecurityMasks.Owner
-        };
-
-        if (Audit)
+        try
         {
-            searcher.SecurityMasks |= SecurityMasks.Sacl;
-        }
+            using DirectoryEntry root = GetRootEntry(_entryBuilder);
+            using DirectorySearcher searcher = new(root, LdapFilter, [SecurityDescriptor])
+            {
+                SizeLimit = Top,
+                Tombstone = IncludeDeletedObjects,
+                SearchScope = SearchScope,
+                PageSize = PageSize,
+                SecurityMasks = SecurityMasks.Group |
+                    SecurityMasks.Dacl |
+                    SecurityMasks.Owner
+            };
 
-        foreach (SearchResult obj in searcher.FindAll())
-        {
-            if (obj.Properties[SecurityDescriptor][0] is not byte[] descriptor)
+            if (Audit)
             {
-                obj.WriteInvalidSecurityDescriptorError(this);
-                continue;
+                searcher.SecurityMasks |= SecurityMasks.Sacl;
             }
 
-            AclBuilder builder = new(obj.Path, descriptor);
-            WriteObject(
-                builder.EnumerateAccessRules(_map),
-                enumerateCollection: true);
-
-            if (Audit)
+            foreach (SearchResult obj in searcher.FindAll())
             {
+                if (!obj.Properties.Contains(SecurityDescriptor) ||
+                    obj.Properties[SecurityDescriptor][0] is not byte[] descriptor)
+                {
+                    obj.WriteInvalidSecurityDescriptorError(this);
+                    continue;
+                }
+
+                AclBuilder builder = new(obj.Path, descriptor);
                 WriteObject(
-                    builder.EnumerateAuditRules(_map),
+                    builder.EnumerateAccessRules(_map!),
                     enumerateCollection: true);
+
+                if (Audit)
+                {
+                    WriteObject(
+                        builder.EnumerateAuditRules(_map!),
+                        enumerateCollection: true);
+                }
             }
         }
+        catch (Exception _) when (_ is PipelineStoppedException or FlowControlException)
+        {
+            throw;
+        }
+        catch (IdentityNotMappedException exception)
+        {
+            exception.WriteIdentityNotFoundError(this);
+        }
+        catch (Exception exception)
+        {
+            exception.WriteUnderterminedError(this);
+        }
     }
 
     private string? TryGetIdentityPath(string? identity) => identity switch