Skip to content

Refering to commit "use concatenated strings instead of repeated printfs". #1

@sighook

Description

@sighook

Hi rofl0r,

Here you change many fprintf calls to one. And, as far as I see, in the old code, only the first instruction will be executed after the else statement. After the patch, the behavior is different.

I looked Ilumos and did not find any differences from the old code.

Unfortunately, I do not understand the code to say for sure. But I believe that the original developers forgot the indentation, not the curly braces. What do you think about this?

P.S. Huge thanks for what you're doing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions