Merge pull request #104 from rust-secure-code/clippy

cargo clippy --fix

Author: Shnatsel

src/common.rs

@@ -316,6 +316,6 @@ mod tests {
     }
 
     fn enabled(key: &str) -> bool {
-        var(key).map_or(false, |value| value != "0")
+        var(key).is_ok_and(|value| value != "0")
     }
 }

src/crates_cache.rs

@@ -149,7 +149,7 @@ impl CratesCache {
             }
             request.call()
         }
-        .map_err(|e| io::Error::new(ErrorKind::Other, e))?;
+        .map_err(io::Error::other)?;
 
         // Not modified.
         if response.status() == 304 {

src/publishers.rs

@@ -3,7 +3,7 @@ use crate::crates_cache::{CacheState, CratesCache};
 use serde::{Deserialize, Serialize};
 use std::{
     collections::BTreeMap,
-    io::{self, ErrorKind},
+    io::{self},
     time::Duration,
 };
 
@@ -94,10 +94,7 @@ fn get_with_retry(
     client: &mut RateLimitedClient,
     attempts: u8,
 ) -> Result<ureq::Response, io::Error> {
-    let mut resp = client
-        .get(url)
-        .call()
-        .map_err(|e| io::Error::new(ErrorKind::Other, e))?;
+    let mut resp = client.get(url).call().map_err(io::Error::other)?;
 
     let mut count = 1;
     let mut wait = 5;
@@ -108,10 +105,7 @@ fn get_with_retry(
         );
         std::thread::sleep(std::time::Duration::from_secs(wait));
 
-        resp = client
-            .get(url)
-            .call()
-            .map_err(|e| io::Error::new(ErrorKind::Other, e))?;
+        resp = client.get(url).call().map_err(io::Error::other)?;
 
         count += 1;
         wait *= 3;