-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
run-make-support: add #[must_use] to helpers where suitable #125703
Copy link
Copy link
Closed
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
For command wrappers like
Rustc, they often have intermediate helper methods and actual "terminal" functions that executes the built command (e.g.run,run_fail,run_fail_assert_exit_code). Currently, it is easy to forget to call "terminal" functions.For example,
does not actually execute and can unexpectedly silently pass. We should annotate intermediate helper methods with
#[must_use]to ensure the built command is consumed, i.e. by executing the command.