-
-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Agreement
- This is not a duplicate of an existing issue
- I have read the guidelines for Contributing to Roots Projects
- This is not a personal support request that should be posted on the Roots Discourse community
Describe the issue
After upgrading to Bud 6.24.0 I started seeing this deprecation warning:
Module Warning (from ../node_modules/sass-loader/dist/cjs.js):
Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
More info: https://sass-lang.com/d/legacy-js-api
Everything still works and I can silence the warning using the following config, but would be great if we could fix this for everyone.
export default async (bud) => {
// Use the build.before action to ensure Sass is available
// https://discourse.roots.io/t/bud-6-3-0-and-sass/23570/3
bud.hooks.action('build.before', async (bud) => {
// Set custom Sass options
bud.build.items.sass.setOptions({
sassOptions: {
// Silience legacy API warning
// https://sass-lang.com/documentation/breaking-changes/legacy-js-api/
silenceDeprecations: ['legacy-js-api']
},
sourceMap: true,
});
});
// Rest of config
};Expected Behavior
No Sass deprecation warnings
Actual Behavior
I get the Sass legacy JS API warning
Steps To Reproduce
- Upgrade to Bud 6.24.0
- Run
yarn start
version
6.24.0
Logs
No response
Configuration
No response
Relevant .budfiles
No response
daverobertson, ouun, JUVOJustin, funkysoul, templeman and 2 more
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working