added github build action

Author: reillypascal

.github/workflows/cmake.yml

@@ -0,0 +1,31 @@
+name: juce-ci
+
+on: [push]
+
+env:
+  BUILD_TYPE: Release
+
+jobs:
+  build:
+    runs-on: ${{matrix.os}}
+    strategy:
+      matrix:
+        os: [windows-latest, macos-latest]
+
+    steps:
+      - name: "Preparation"
+        uses: actions/checkout@v2
+
+      - name: "(JUCE) Clone Repository"
+        uses: actions/checkout@v2
+        with:
+          repository: juce-framework/JUCE
+          path: ${{runner.workspace}}/RSAlgorithmicVerb/JUCE
+
+      - name: "Create Build Environment"
+        working-directory: ${{runner.workspace}}/RSAlgorithmicVerb
+        run: cmake -S . -B build
+
+      - name: "Build"
+        working-directory: ${{runner.workspace}}/RSAlgorithmicVerb
+        run: cmake --build build --config $BUILD_TYPE

CMakeLists.txt

@@ -12,13 +12,13 @@ cmake_minimum_required(VERSION 3.22)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
-set(CMAKE_BUILD_TYPE Debug)
+# set(CMAKE_BUILD_TYPE Debug)
 
 # The top-level CMakeLists.txt file for a project must contain a literal, direct call to the
 # `project()` command. `project()` sets up some helpful variables that describe source/binary
 # directories, and the current project version. This is a standard CMake command.
 
-project(RSAlgorithmicVerb VERSION 0.5.4)
+project(RSAlgorithmicVerb VERSION 0.5.5)
 
 # If you've installed JUCE somehow (via a package manager, or directly using the CMake install
 # target), you'll need to tell this project that it depends on the installed copy of JUCE. If you've
@@ -53,9 +53,9 @@ juce_add_plugin(${PROJECT_NAME}
     # NEEDS_MIDI_OUTPUT TRUE/FALSE              # Does the plugin need midi output?
     IS_MIDI_EFFECT FALSE                 # Is this plugin a MIDI effect?
     # EDITOR_WANTS_KEYBOARD_FOCUS TRUE/FALSE    # Does the editor need keyboard focus?
-    COPY_PLUGIN_AFTER_BUILD TRUE        # Should the plugin be installed to a default location after building?
-    VST3_COPY_DIR "/Library/Audio/Plug-Ins/VST3"
-    AU_COPY_DIR "/Library/Audio/Plug-Ins/Components"
+    # COPY_PLUGIN_AFTER_BUILD TRUE        # Should the plugin be installed to a default location after building?
+    # VST3_COPY_DIR "/Library/Audio/Plug-Ins/VST3"
+    # AU_COPY_DIR "/Library/Audio/Plug-Ins/Components"
     PLUGIN_MANUFACTURER_CODE Rspi               # A four-character manufacturer id with at least one upper-case character
     PLUGIN_CODE Rsav                            # A unique four-character plugin id with exactly one upper-case character
                                                 # GarageBand 10.3 requires the first letter to be upper-case, and the remaining letters to be lower-case

README.md

@@ -57,7 +57,7 @@ Linux/Windows releases are coming! For now, compiler targets are available for L
 
 ## Compiling with CMake
 - Clone the [JUCE repo](https://github.com/juce-framework/JUCE) into the working folder
-- Run the following for a CLI build:
+- Run the following for a CLI build. Note that you may need to run these with `sudo`:
 ```sh
 # sets up a default build:
 cmake -S . -B build
@@ -66,6 +66,8 @@ cmake -S . -B build/ -D CMAKE_BUILD_TYPE=Debug
 # or
 cmake -S . -B build/ -D CMAKE_BUILD_TYPE=Release
 
+# you can add the flag -D COPY_PLUGIN_AFTER_BUILD=TRUE to copy the built files to the default location on macOS
+
 # after running one of the above three options, run
 cmake --build build
 ```

Source/GardnerRooms.cpp

@@ -1,14 +1,7 @@
-/*
-  ==============================================================================
-    
-    
-
-  ==============================================================================
-*/
+// Allpass loop room reverbs from Gardner, 1992
 
 #include "GardnerRooms.h"
 
-//==============================================================================
 GardnerSmallRoom::GardnerSmallRoom() = default;
 
 GardnerSmallRoom::~GardnerSmallRoom() = default;
@@ -24,9 +17,6 @@ void GardnerSmallRoom::prepare(const juce::dsp::ProcessSpec &spec)
     delay5.prepare(spec);
     delay6.prepare(spec);
 
-    // for (auto& delay : delays)
-    //     delay.prepare(spec);
-    
     dampingFilter.prepare(spec);
     dampingFilter.setType(juce::dsp::FirstOrderTPTFilterType::lowpass);
 
@@ -69,9 +59,7 @@ void GardnerSmallRoom::processBlock(juce::AudioBuffer<float> &buffer, juce::Midi
         float delay5Time = 30 * samplesPerMs * parameters.roomSize + channelDelayOffset[channel]; // for modulation
         delay5.setDelay(delay5Time);
         delay6.setDelay(36 * samplesPerMs * parameters.roomSize + channelDelayOffset[channel]);
-        
-        // for (size_t delay = 0; delay < delayTimesMs.size(); ++delay) {}
-        
+                
         for (int sample = 0; sample < buffer.getNumSamples(); ++sample)
         {
             // LFO

Source/GardnerRooms.h

@@ -1,10 +1,4 @@
-/*
-  ==============================================================================
-
-	Allpass loop rooms from Gardner 1992
-
-  ==============================================================================
-*/
+// Allpass loop room reverbs from Gardner, 1992
 
 #pragma once
 
@@ -14,10 +8,6 @@
 #include "ProcessorBase.h"
 #include "Utilities.h"
 
-// want shorter alias because of repetitive syntax for std::vector with size as *member* variable
-typedef juce::dsp::DelayLine<float> DelayLine;
-
-//==============================================================================
 class GardnerSmallRoom :public ReverbProcessorBase
 {
 public:
@@ -44,9 +34,6 @@ class GardnerSmallRoom :public ReverbProcessorBase
     juce::dsp::DelayLine<float> delay4 { 22050 };
     juce::dsp::DelayLine<float> delay5 { 22050 };
     juce::dsp::DelayLine<float> delay6 { 22050 };
-    // need to use this verbose syntax for initializing with size as *member* variable
-    std::vector<DelayLine> delays = std::vector<DelayLine>(6, DelayLine(22050));
-    std::vector<float> delayTimesMs { 24.0f, 22.0f, 8.3f, 4.7f, 30.0f, 36.0f };
 
     juce::dsp::FirstOrderTPTFilter<float> dampingFilter;
 

Source/LFO.h

@@ -6,7 +6,6 @@
 
 #include <JuceHeader.h>
 
-//==============================================================================
 struct SignalGenData
 {
 	SignalGenData() {}
@@ -27,7 +26,6 @@ class IAudioSignalGenerator
 	virtual const SignalGenData renderAudioOutput() = 0;
 };
 
-//==============================================================================
 enum class generatorWaveform { triangle, sin, saw };
 
 struct OscillatorParameters

Source/PluginEditor.cpp

@@ -1,10 +1,8 @@
 // Graphical interface for the plugin
 
-
 #include "PluginProcessor.h"
 #include "PluginEditor.h"
 
-//==============================================================================
 RSAlgorithmicVerbAudioProcessorEditor::RSAlgorithmicVerbAudioProcessorEditor (RSAlgorithmicVerbAudioProcessor& p, juce::AudioProcessorValueTreeState& vts)
     : AudioProcessorEditor (&p), audioProcessor (p), valueTreeState(vts)
 {

Source/PluginEditor.h

@@ -7,16 +7,12 @@
 #include "GuiStyles.h"
 #include "PluginProcessor.h"
 
-//==============================================================================
-/**
-*/
 class RSAlgorithmicVerbAudioProcessorEditor  : public juce::AudioProcessorEditor
 {
 public:
     RSAlgorithmicVerbAudioProcessorEditor (RSAlgorithmicVerbAudioProcessor&, juce::AudioProcessorValueTreeState&);
     ~RSAlgorithmicVerbAudioProcessorEditor() override;
-
-    //==============================================================================
+    
     void paint (juce::Graphics&) override;
     void resized() override;
 

Source/PluginProcessor.cpp

@@ -20,7 +20,6 @@
 #include "PluginProcessor.h"
 #include "PluginEditor.h"
 
-//==============================================================================
 RSAlgorithmicVerbAudioProcessor::RSAlgorithmicVerbAudioProcessor()
 #ifndef JucePlugin_PreferredChannelConfigurations
      : AudioProcessor (BusesProperties()

Source/PluginProcessor.h

@@ -44,9 +44,6 @@ struct ProcessorFactory
     };
 };
 
-//==============================================================================
-/**
-*/
 class RSAlgorithmicVerbAudioProcessor  : public juce::AudioProcessor
                             #if JucePlugin_Enable_ARA
                              , public juce::AudioProcessorARAExtension