Deprecated golang.org/x/oauth2 error with latest Benthos version

[tifennlegoff]

Hey, I'm currently upgrading our Benthos, and I see this error in logs

deprecated: golang.org/x/oauth2: Transport.CancelRequest no longer does anything; use context

We're using oAuth2 auth with our pipelines.

processor_resources:
  - label: analyze_http
    http:
      parallel: true
      drop_on: [500, 501, 400, 404, 403, 406]
      backoff_on: [408, 429, 502, 503, 504]
      max_retry_backoff: "120s"
      timeout: "60s"
      url: "x"
      verb: POST
      headers:
        Content-Type: application/json
        Content-Encoding: gzip
      oauth2:
        enabled: true
        client_key: xxxxxx  # Consumer app clientId
        client_secret: xxxxxx  # consumer app secret
        token_url: xxxxxx
        scopes:
          - xxxxxx  # API app clientId
      rate_limit: 100

Do you know if I should be worries about it? Should we modify a setting?
Thanks!

[tifennlegoff]

I guess it's this function https://pkg.go.dev/golang.org/x/oauth2#Transport.CancelRequest
I'm not sure but I think it's fine 🤔

[tifennlegoff]

Yeah, I guess it should be fine, I saw on the go.mod from our previous Benthos version, that we used x/oauth2 v0.17.0 and it was already depreciated.
We probably missed this error 😢

[tifennlegoff]

But just a little question, could this have an impact on something like timeout handle?

[josephwoodward]

There is a similar issue logged here.

If you're seeing that deprecation warning then there must be something calling it, are you able to identify what it could be? Also, what version of Benthos are you using?

[tifennlegoff]

I see that we're using Benthos v4.53.1. Unfortunately, I'm not sure what is calling it 😢