ThisCallOnStaticMethodToStaticCall rule useless for the Symfony assertions because the method aren't being considered as static

[florentpoujol]

Hello there

The Symfony WebTestCase class has a trait WebTestAssertionsTrait which only contains 3 traits which themselves contains the assertion methods that are all static.

It seems that the method \Rector\NodeCollector\StaticAnalyzer::isStaticMethod, used by the ThisCallOnStaticMethodToStaticCall rule do not detect theses methods as being static because the call to $classMethod = $class->getMethod($methodName); returns null.

This render the rule (a slightly modified version that do run within PHPUnit classes) useless for theses methods.

I'm just wondering if this is a bug (because the methods are within traits probably) or something you would not consider as such.

Thanks for the answers.