Skip to content

Commit be502c4

Browse files
committed
Potential fix
1 parent be33d7c commit be502c4

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,13 @@ public function refactor(Node $node): ?Class_
160160

161161
$invokeParams = $this->createInvokeParams($node);
162162

163-
$invokeClassMethod->params = array_merge($invokeParams, [$executeClassMethod->params[1]]);
163+
$executeClassMethodParams = array_merge($invokeParams, [$executeClassMethod->params[1]]);
164+
165+
// Ensure that optional parameters are listed last in the argument list
166+
$invokeClassMethod->params = array_merge(
167+
array_filter($executeClassMethodParams, fn(Param $param) => is_null($param->default)),
168+
array_filter($executeClassMethodParams, fn(Param $param) => !is_null($param->default)),
169+
);
164170

165171
// 6. remove parent class
166172
$node->extends = null;

0 commit comments

Comments
 (0)