[experiment] skip beforeTraverse() and afterTraverse() as never used

TomasVotruba · TomasVotruba · commit db653c5bb6ae · 2025-12-26T00:39:31.000+01:00
diff --git a/rules/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector.php b/rules/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector.php
@@ -152,7 +152,7 @@ private function isAllowedExpr(Expr $expr, Scope $scope): bool
             return false;
         }
 
-        $type = $this->allAssignNodePropertyTypeInferer->inferProperty($property, $classReflection, $this->file);
+        $type = $this->allAssignNodePropertyTypeInferer->inferProperty($property, $classReflection, $this->getFile());
         if (! $type instanceof Type) {
             return false;
         }
diff --git a/rules/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector.php b/rules/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector.php
@@ -68,7 +68,8 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $oldTokens = $this->file->getOldTokens();
+        $oldTokens = $this->getFile()
+            ->getOldTokens();
         if ($this->isIfConditionFollowedByOpeningCurlyBracket($node, $oldTokens)) {
             return null;
         }
diff --git a/rules/CodeQuality/Rector/NotEqual/CommonNotEqualRector.php b/rules/CodeQuality/Rector/NotEqual/CommonNotEqualRector.php
@@ -62,7 +62,8 @@ public function refactor(Node $node): ?NotEqual
         $tokenEndPos = $node->getEndTokenPos();
 
         for ($i = $tokenStartPos; $i < $tokenEndPos; ++$i) {
-            $token = $this->file->getOldTokens()[$i];
+            $token = $this->getFile()
+                ->getOldTokens()[$i];
 
             if ((string) $token === '<>') {
                 $token->text = '!=';
diff --git a/rules/CodingStyle/Rector/Encapsed/WrapEncapsedVariableInCurlyBracesRector.php b/rules/CodingStyle/Rector/Encapsed/WrapEncapsedVariableInCurlyBracesRector.php
@@ -52,7 +52,8 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $hasVariableBeenWrapped = false;
-        $oldTokens = $this->file->getOldTokens();
+        $oldTokens = $this->getFile()
+            ->getOldTokens();
 
         foreach ($node->parts as $index => $nodePart) {
             if ($nodePart instanceof Variable && $nodePart->getStartTokenPos() >= 0) {
diff --git a/rules/DeadCode/Rector/Concat/RemoveConcatAutocastRector.php b/rules/DeadCode/Rector/Concat/RemoveConcatAutocastRector.php
@@ -79,7 +79,8 @@ private function removeStringCast(Expr $expr): Expr
         }
 
         $targetExpr = $expr->expr;
-        $tokens = $this->file->getOldTokens();
+        $tokens = $this->getFile()
+            ->getOldTokens();
 
         if ($expr->expr instanceof BinaryOp) {
             $castStartTokenPos = $expr->getStartTokenPos();
diff --git a/rules/Php53/Rector/Ternary/TernaryToElvisRector.php b/rules/Php53/Rector/Ternary/TernaryToElvisRector.php
@@ -77,7 +77,8 @@ public function provideMinPhpVersion(): int
 
     private function isParenthesized(Expr $ifExpr, Expr $elseExpr): bool
     {
-        $tokens = $this->file->getOldTokens();
+        $tokens = $this->getFile()
+            ->getOldTokens();
 
         $ifExprTokenEnd = $ifExpr->getEndTokenPos();
         $elseExprTokenStart = $elseExpr->getStartTokenPos();
diff --git a/rules/Php54/Rector/Array_/LongArrayToShortArrayRector.php b/rules/Php54/Rector/Array_/LongArrayToShortArrayRector.php
@@ -78,7 +78,8 @@ public function refactor(Node $node): ?Node
 
         $node->setAttribute(AttributeKey::KIND, Array_::KIND_SHORT);
 
-        $tokens = $this->file->getOldTokens();
+        $tokens = $this->getFile()
+            ->getOldTokens();
 
         $startTokenPos = $node->getStartTokenPos();
         $endTokenPos = $node->getEndTokenPos();
diff --git a/rules/Php74/Rector/ArrayDimFetch/CurlyToSquareBracketArrayStringRector.php b/rules/Php74/Rector/ArrayDimFetch/CurlyToSquareBracketArrayStringRector.php
@@ -63,7 +63,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $this->isFollowedByCurlyBracket($this->file, $node)) {
+        if (! $this->isFollowedByCurlyBracket($this->getFile(), $node)) {
             return null;
         }
 
diff --git a/rules/Php74/Rector/Ternary/ParenthesizeNestedTernaryRector.php b/rules/Php74/Rector/Ternary/ParenthesizeNestedTernaryRector.php
@@ -68,7 +68,7 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
-            if ($this->parenthesizedNestedTernaryAnalyzer->isParenthesized($this->file, $node)) {
+            if ($this->parenthesizedNestedTernaryAnalyzer->isParenthesized($this->getFile(), $node)) {
                 return null;
             }
 
diff --git a/rules/Php82/Rector/Encapsed/VariableInStringInterpolationFixerRector.php b/rules/Php82/Rector/Encapsed/VariableInStringInterpolationFixerRector.php
@@ -51,7 +51,8 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $oldTokens = $this->file->getOldTokens();
+        $oldTokens = $this->getFile()
+            ->getOldTokens();
         $hasChanged = false;
 
         foreach ($node->parts as $part) {
diff --git a/rules/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector.php b/rules/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector.php
@@ -53,7 +53,8 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $oldTokens = $this->file->getOldTokens();
+        $oldTokens = $this->getFile()
+            ->getOldTokens();
 
         $loop = 1;
         while (isset($oldTokens[$node->var->getStartTokenPos() + $loop])) {
diff --git a/rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php b/rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php
@@ -4,13 +4,13 @@
 
 namespace Rector\Php85\Rector\FuncCall;
 
-use PHPStan\Type\UnionType;
-use PHPStan\Type\TypeCombinator;
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\UnionType;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PHPStan\ParametersAcceptorSelectorVariantsWrapper;
diff --git a/rules/Php85/Rector/Switch_/ColonAfterSwitchCaseRector.php b/rules/Php85/Rector/Switch_/ColonAfterSwitchCaseRector.php
@@ -50,7 +50,8 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $hasChanged = false;
-        $oldTokens = $this->file->getOldTokens();
+        $oldTokens = $this->getFile()
+            ->getOldTokens();
 
         foreach ($node->cases as $key => $case) {
             $cond = $case->cond;
diff --git a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromAssignsRector.php b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromAssignsRector.php
@@ -158,7 +158,7 @@ public function refactor(Node $node): ?Node
             $inferredType = $this->allAssignNodePropertyTypeInferer->inferProperty(
                 $property,
                 $classReflection,
-                $this->file
+                $this->getFile()
             );
             if (! $inferredType instanceof Type) {
                 continue;
diff --git a/rules/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector.php b/rules/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector.php
@@ -63,7 +63,7 @@ function someFunction(int $number)
     public function refactor(Node $node): ?FileNode
     {
         // shebang files cannot have declare strict types
-        if ($this->file->hasShebang()) {
+        if ($this->getFile()->hasShebang()) {
             return null;
         }
 
diff --git a/src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php b/src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php
@@ -59,21 +59,7 @@ public function removeVisitor(NodeVisitor $visitor): void
     public function traverse(array $nodes): array
     {
         $this->stopTraversal = false;
-        foreach ($this->visitors as $visitor) {
-            if (null !== $return = $visitor->beforeTraverse($nodes)) {
-                $nodes = $return;
-            }
-        }
-
-        $nodes = $this->traverseArray($nodes);
-        for ($i = \count($this->visitors) - 1; $i >= 0; --$i) {
-            $visitor = $this->visitors[$i];
-            if (null !== $return = $visitor->afterTraverse($nodes)) {
-                $nodes = $return;
-            }
-        }
-
-        return $nodes;
+        return $this->traverseArray($nodes);
     }
 
     /**
diff --git a/src/PostRector/Rector/AbstractPostRector.php b/src/PostRector/Rector/AbstractPostRector.php
@@ -41,6 +41,7 @@ protected function addRectorClassWithLine(Node $node): void
         Assert::isInstanceOf($this->file, File::class);
 
         $rectorWithLineChange = new RectorWithLineChange(static::class, $node->getStartLine());
-        $this->file->addRectorClassWithLine($rectorWithLineChange);
+        $this->getFile()
+            ->addRectorClassWithLine($rectorWithLineChange);
     }
 }
diff --git a/src/Rector/AbstractRector.php b/src/Rector/AbstractRector.php
@@ -59,6 +59,9 @@ abstract class AbstractRector extends NodeVisitorAbstract implements RectorInter
 
     protected NodeComparator $nodeComparator;
 
+    /**
+     * @deprecated Use getFile() instead
+     */
     protected File $file;
 
     protected Skipper $skipper;
@@ -99,23 +102,12 @@ public function autowire(
 
     /**
      * @final Avoid override to prevent unintended side-effects. Use enterNode() or @see \Rector\Contract\PhpParser\DecoratingNodeVisitorInterface instead.
-     *
      * @internal
      *
      * @return Node[]|null
      */
     public function beforeTraverse(array $nodes): ?array
     {
-        // workaround for file around refactor()
-        $file = $this->currentFileProvider->getFile();
-        if (! $file instanceof File) {
-            throw new ShouldNotHappenException(
-                'File object is missing. Make sure you call $this->currentFileProvider->setFile(...) before traversing.'
-            );
-        }
-
-        $this->file = $file;
-
         return null;
     }
 
@@ -124,11 +116,12 @@ public function beforeTraverse(array $nodes): ?array
      */
     final public function enterNode(Node $node): int|Node|null|array
     {
-        if (is_a($this, HTMLAverseRectorInterface::class, true) && $this->file->containsHTML()) {
+        if (is_a($this, HTMLAverseRectorInterface::class, true) && $this->getFile()->containsHTML()) {
             return null;
         }
 
-        $filePath = $this->file->getFilePath();
+        $filePath = $this->getFile()
+            ->getFilePath();
         if ($this->skipper->shouldSkipCurrentNode($this, $filePath, static::class, $node)) {
             return null;
         }
@@ -161,14 +154,27 @@ final public function enterNode(Node $node): int|Node|null|array
 
             // notify this rule changed code
             $rectorWithLineChange = new RectorWithLineChange(static::class, $originalNode->getStartLine());
-            $this->file->addRectorClassWithLine($rectorWithLineChange);
+            $this->getFile()
+                ->addRectorClassWithLine($rectorWithLineChange);
 
             return $refactoredNodeOrState;
         }
 
         return $this->postRefactorProcess($originalNode, $node, $refactoredNodeOrState, $filePath);
     }
 
+    protected function getFile(): File
+    {
+        $file = $this->currentFileProvider->getFile();
+        if (! $file instanceof File) {
+            throw new ShouldNotHappenException(
+                'File object is missing. Make sure you call $this->currentFileProvider->setFile(...) before traversing.'
+            );
+        }
+
+        return $file;
+    }
+
     protected function isName(Node $node, string $name): bool
     {
         return $this->nodeNameResolver->isName($node, $name);
@@ -243,7 +249,8 @@ private function postRefactorProcess(
         $this->createdByRuleDecorator->decorate($refactoredNode, $originalNode, static::class);
 
         $rectorWithLineChange = new RectorWithLineChange(static::class, $originalNode->getStartLine());
-        $this->file->addRectorClassWithLine($rectorWithLineChange);
+        $this->getFile()
+            ->addRectorClassWithLine($rectorWithLineChange);
 
         /** @var MutatingScope|null $currentScope */
         $currentScope = $node->getAttribute(AttributeKey::SCOPE);

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ private function isAllowedExpr(Expr $expr, Scope $scope): bool`
`152`	`152`	`return false;`
`153`	`153`	`}`
`154`	`154`
`155`		`- $type = $this->allAssignNodePropertyTypeInferer->inferProperty($property, $classReflection, $this->file);`
	`155`	`+ $type = $this->allAssignNodePropertyTypeInferer->inferProperty($property, $classReflection, $this->getFile());`
`156`	`156`	`if (! $type instanceof Type) {`
`157`	`157`	`return false;`
`158`	`158`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,8 @@ public function refactor(Node $node): ?Node`
`68`	`68`	`return null;`
`69`	`69`	`}`
`70`	`70`
`71`		`- $oldTokens = $this->file->getOldTokens();`
	`71`	`+ $oldTokens = $this->getFile()`
	`72`	`+ ->getOldTokens();`
`72`	`73`	`if ($this->isIfConditionFollowedByOpeningCurlyBracket($node, $oldTokens)) {`
`73`	`74`	`return null;`
`74`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ public function getNodeTypes(): array`
`52`	`52`	`public function refactor(Node $node): ?Node`
`53`	`53`	`{`
`54`	`54`	`$hasVariableBeenWrapped = false;`
`55`		`- $oldTokens = $this->file->getOldTokens();`
	`55`	`+ $oldTokens = $this->getFile()`
	`56`	`+ ->getOldTokens();`
`56`	`57`
`57`	`58`	`foreach ($node->parts as $index => $nodePart) {`
`58`	`59`	`if ($nodePart instanceof Variable && $nodePart->getStartTokenPos() >= 0) {`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,8 @@ private function removeStringCast(Expr $expr): Expr`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`$targetExpr = $expr->expr;`
`82`		`- $tokens = $this->file->getOldTokens();`
	`82`	`+ $tokens = $this->getFile()`
	`83`	`+ ->getOldTokens();`
`83`	`84`
`84`	`85`	`if ($expr->expr instanceof BinaryOp) {`
`85`	`86`	`$castStartTokenPos = $expr->getStartTokenPos();`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ public function provideMinPhpVersion(): int`
`77`	`77`
`78`	`78`	`private function isParenthesized(Expr $ifExpr, Expr $elseExpr): bool`
`79`	`79`	`{`
`80`		`- $tokens = $this->file->getOldTokens();`
	`80`	`+ $tokens = $this->getFile()`
	`81`	`+ ->getOldTokens();`
`81`	`82`
`82`	`83`	`$ifExprTokenEnd = $ifExpr->getEndTokenPos();`
`83`	`84`	`$elseExprTokenStart = $elseExpr->getStartTokenPos();`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function getNodeTypes(): array`
`63`	`63`	`*/`
`64`	`64`	`public function refactor(Node $node): ?Node`
`65`	`65`	`{`
`66`		`- if (! $this->isFollowedByCurlyBracket($this->file, $node)) {`
	`66`	`+ if (! $this->isFollowedByCurlyBracket($this->getFile(), $node)) {`
`67`	`67`	`return null;`
`68`	`68`	`}`
`69`	`69`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function refactor(Node $node): ?Node`
`68`	`68`	`return null;`
`69`	`69`	`}`
`70`	`70`
`71`		`- if ($this->parenthesizedNestedTernaryAnalyzer->isParenthesized($this->file, $node)) {`
	`71`	`+ if ($this->parenthesizedNestedTernaryAnalyzer->isParenthesized($this->getFile(), $node)) {`
`72`	`72`	`return null;`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ public function getNodeTypes(): array`
`51`	`51`	`*/`
`52`	`52`	`public function refactor(Node $node): ?Node`
`53`	`53`	`{`
`54`		`- $oldTokens = $this->file->getOldTokens();`
	`54`	`+ $oldTokens = $this->getFile()`
	`55`	`+ ->getOldTokens();`
`55`	`56`	`$hasChanged = false;`
`56`	`57`
`57`	`58`	`foreach ($node->parts as $part) {`