Merge branch 'develop'

Author: santiagolizardo

eslint.config.js

@@ -39,8 +39,14 @@ module.exports = defineConfig([
 
             "import/resolver": {
                 node: {
-                    paths: ["src"],
-                    extensions: [".js", ".jsx", ".ts"],
+                    // allow resolving absolute imports from package src folders
+                    paths: ["src", "packages/app/src", "packages/native-components-lib/src", "packages/*/src"],
+                    extensions: [".js", ".jsx", ".ts", ".tsx", ".json"],
+                },
+                typescript: {
+                    project: ["./packages/app/tsconfig.json", "./packages/native-components-lib/tsconfig.json"],
+                    extensions: [".js", ".jsx", ".ts", ".tsx"],
+                    alwaysTryTypes: true,
                 },
             },
         },

packages/app/package.json

@@ -44,6 +44,7 @@
     "@vitejs/plugin-react": "^5.1.2",
     "@vitest/coverage-v8": "^4.0.15",
     "eslint": "^9.39.1",
+    "eslint-import-resolver-typescript": "^3.5.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
@@ -80,4 +81,4 @@
       "last 1 safari version"
     ]
   }
-}
+}

packages/app/src/hooks/useTheme.ts

@@ -3,7 +3,7 @@ import { useEffect, useState } from "react";
 
 type Theme = "light" | "dark";
 
-export function useTheme(): { theme: Theme; toggleTheme: () => void; setTheme: (theme: Theme) => void } {
+export function useTheme(): { theme: Theme; toggleTheme: () => void; setTheme: (newTheme: Theme) => void } {
     // Initialize theme with localStorage or default to "light"
     const [theme, setThemeState] = useState<Theme>(() => {
         const savedTheme = localStorage.getItem("theme");

packages/app/src/services/passwords.ts

@@ -29,6 +29,25 @@ const CHAR_SETS = {
     symbols: "!@#$%^&*",
 };
 
+// Returns a cryptographically secure random integer in [0, max)
+function getSecureRandomInt(max: number): number {
+    if (max <= 0 || max > Number.MAX_SAFE_INTEGER) {
+        throw new Error("Invalid max value for random integer");
+    }
+    // Range is [0, max)
+    const rand = new Uint32Array(1);
+    let x;
+    // Avoid bias: only accept numbers < rangeLimit
+    // rangeLimit = Math.floor(2**32 / max) * max;
+    // see https://stackoverflow.com/a/78239136 for explanation
+    const rangeLimit = Math.floor(0x100000000 / max) * max;
+    do {
+        window.crypto.getRandomValues(rand);
+        x = rand[0];
+    } while (x >= rangeLimit);
+    return x % max;
+}
+
 function removeAmbiguous(charset: string): string {
     return charset
         .split("")
@@ -37,7 +56,7 @@ function removeAmbiguous(charset: string): string {
 }
 
 function getRandomChar(charset: string): string {
-    const index = Math.floor(Math.random() * charset.length);
+    const index = getSecureRandomInt(charset.length);
     return charset[index];
 }
 
@@ -92,7 +111,7 @@ const generatePassword = (settings: PasswordConfiguration): string => {
 
     // Shuffle the final password
     for (let i = guaranteedChars.length - 1; i > 0; i--) {
-        const j = Math.floor(Math.random() * (i + 1));
+        const j = getSecureRandomInt(i + 1);
         [guaranteedChars[i], guaranteedChars[j]] = [guaranteedChars[j], guaranteedChars[i]];
     }
 

packages/app/src/setupTests.js

@@ -3,6 +3,6 @@
 // expect(element).toHaveTextContent(/react/i)
 // learn more: https://github.com/testing-library/jest-dom
 import "@testing-library/jest-dom/vitest";
-import configJson from "../public/config";
+import configJson from "../public/config.json";
 
 window.env = configJson;

packages/app/src/utilities/requests.ts

@@ -4,13 +4,13 @@ const requestEntity = (url: string) => {
     return secureApiFetch(url, { method: "GET" });
 };
 
-const requestEntities = (url: string, params?: Record<string, any>) => {
+const requestEntities = (url: string, params?: Record<string, string>) => {
     const fullUrl = url + (params ? "?" + new URLSearchParams(params).toString() : "");
     return secureApiFetch(fullUrl, { method: "GET" });
 };
 
-const requestEntityPost = (url: string, data?: FormData | Record<string, any>) => {
-    const params: Record<string, any> = {
+const requestEntityPost = (url: string, data?: FormData | Record<string, string>) => {
+    const params: Record<string, string | FormData | { "Content-Type": string }> = {
         method: "POST",
     };
     if (data) {
@@ -27,7 +27,7 @@ const requestEntityPost = (url: string, data?: FormData | Record<string, any>) =
     return secureApiFetch(url, params);
 };
 
-const requestEntityPut = (url: string, data: any) => {
+const requestEntityPut = (url: string, data: Record<string, string>) => {
     return secureApiFetch(url, {
         method: "PUT",
         body: JSON.stringify(data),
@@ -37,7 +37,7 @@ const requestEntityPut = (url: string, data: any) => {
     });
 };
 
-const requestEntityPatch = (url: string, data: any) => {
+const requestEntityPatch = (url: string, data: Record<string, string>) => {
     return secureApiFetch(url, {
         method: "PATCH",
         body: JSON.stringify(data),