fix(tags): update cursor position when tap on embed block

Author: realth000

lib/src/tags/hide/hide_builer.dart

@@ -93,6 +93,8 @@ final class BBCodeHideEmbedBuilder extends EmbedBuilder {
           ..editorFocusNode?.requestFocus()
           ..moveCursorToPosition(offset + 1);
       },
+      onTap: () =>
+          controller.moveCursorToPosition(node.documentOffset + node.length),
       initialData: info,
       emojiPicker: _emojiPicker,
       colorPicker: _colorPicker,
@@ -111,6 +113,7 @@ final class BBCodeHideEmbedBuilder extends EmbedBuilder {
 class _HideCard extends StatefulWidget {
   const _HideCard({
     required this.onEdited,
+    required this.onTap,
     required this.initialData,
     required this.emojiPicker,
     required this.emojiProvider,
@@ -127,6 +130,9 @@ class _HideCard extends StatefulWidget {
   /// Callback when hide content is edited.
   final void Function(BBCodeHideInfo) onEdited;
 
+  /// See comments on _SpoilerCard.onTap
+  final VoidCallback onTap;
+
   final BBCodeEmojiPicker emojiPicker;
   final BBCodeColorPicker? colorPicker;
   final BBCodeColorPicker? backgroundColorPicker;
@@ -289,10 +295,13 @@ class _HideCardState extends State<_HideCard> {
     final tr = context.bbcodeL10n;
 
     return GestureDetector(
-      onTap: () async => showDialog<void>(
-        context: context,
-        builder: (_) => buildDialog(context),
-      ),
+      onTap: () async {
+        widget.onTap.call();
+        await showDialog<void>(
+          context: context,
+          builder: (_) => buildDialog(context),
+        );
+      },
       child: Card(
         margin: EdgeInsets.zero,
         clipBehavior: Clip.hardEdge,

lib/src/tags/spoiler/spoiler_builder.dart

@@ -78,6 +78,8 @@ final class BBCodeSpoilerEmbedBuilder extends EmbedBuilder {
     final info = BBCodeSpoilerInfo.fromJson(node.value.data as String);
 
     return _SpoilerCard(
+      onTap: () =>
+          controller.moveCursorToPosition(node.documentOffset + node.length),
       onEdited: (info) {
         final offset = getEmbedNode(
           controller,
@@ -111,6 +113,7 @@ final class BBCodeSpoilerEmbedBuilder extends EmbedBuilder {
 class _SpoilerCard extends StatefulWidget {
   const _SpoilerCard({
     required this.onEdited,
+    required this.onTap,
     required this.initialData,
     required this.emojiPicker,
     required this.emojiProvider,
@@ -127,6 +130,22 @@ class _SpoilerCard extends StatefulWidget {
   /// Callback when spoiler content is edited.
   final void Function(BBCodeSpoilerInfo) onEdited;
 
+  /// Callback when spoiler card is tapped.
+  ///
+  /// This callback is for anything need update in the outer editor.
+  ///
+  /// Though the function body is defined by caller, things determined to be
+  /// done includes:
+  ///
+  /// * Update cursor position to the end side of spoiler card, when user
+  ///   finish edit, ensuring the content save process in [onEdited] do find
+  ///   the embed node using `getEmbedNode`.
+  ///   This may be an internal but upstream that an embed builder contains
+  ///   [GestureDetector] sometimes make the cursor not moved around embed
+  ///   widget causing `getEmbedNode` failed to find node: a failure on saving
+  ///   contents in document.
+  final VoidCallback onTap;
+
   final BBCodeEmojiPicker emojiPicker;
   final BBCodeColorPicker? colorPicker;
   final BBCodeColorPicker? backgroundColorPicker;
@@ -307,10 +326,14 @@ class _SpoilerCardState extends State<_SpoilerCard> {
   @override
   Widget build(BuildContext context) {
     return GestureDetector(
-      onTap: () async => showDialog<void>(
-        context: context,
-        builder: (_) => buildDialog(context),
-      ),
+      behavior: HitTestBehavior.deferToChild,
+      onTap: () async {
+        widget.onTap.call();
+        await showDialog<void>(
+          context: context,
+          builder: (_) => buildDialog(context),
+        );
+      },
       child: Card(
         margin: EdgeInsets.zero,
         clipBehavior: Clip.hardEdge,